Re: [PATCH v2 4/7] drm/xe/guc: Recommend GuC v70.46.2 for BMG, LNL, DG2

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 6/16/2025 9:33 AM, Lucas De Marchi wrote:
> On Fri, Jun 13, 2025 at 06:55:08PM -0700, Julia Filipchuk wrote:
>> UAPI compatibility version 1.22.2
>>
>> Resolves various bugs. Recommend newer version.
>>
>> Signed-off-by: Julia Filipchuk <julia.filipchuk@intel.com>
>
> Daniele, from the previous  version you seemed to be ok and v2 is mostly
> for the way the patch was submitted, right?

Yup, the change is fine by me.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

>
> Also Cc John
>
> Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/xe/xe_uc_fw.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c 
>> b/drivers/gpu/drm/xe/xe_uc_fw.c
>> index 6d08695186521..4d3ace56f38aa 100644
>> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
>> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
>> @@ -115,10 +115,10 @@ struct fw_blobs_by_type {
>> #define XE_GT_TYPE_ANY XE_GT_TYPE_UNINITIALIZED
>>
>> #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, 
>> major_ver)                    \
>> -    fw_def(BATTLEMAGE,    GT_TYPE_ANY,    major_ver(xe, guc,    
>> bmg,    70, 44, 1))    \
>> -    fw_def(LUNARLAKE,    GT_TYPE_ANY,    major_ver(xe, guc,    
>> lnl,    70, 44, 1))    \
>> +    fw_def(BATTLEMAGE,    GT_TYPE_ANY,    major_ver(xe, guc,    
>> bmg,    70, 45, 2))    \
>> +    fw_def(LUNARLAKE,    GT_TYPE_ANY,    major_ver(xe, guc,    
>> lnl,    70, 45, 2))    \
>>     fw_def(METEORLAKE,    GT_TYPE_ANY,    major_ver(i915, guc,    
>> mtl,    70, 44, 1))    \
>> -    fw_def(DG2,        GT_TYPE_ANY,    major_ver(i915, guc,    
>> dg2,    70, 44, 1))    \
>> +    fw_def(DG2,        GT_TYPE_ANY,    major_ver(i915, guc,    
>> dg2,    70, 45, 2))    \
>>     fw_def(DG1,        GT_TYPE_ANY,    major_ver(i915, guc,    
>> dg1,    70, 44, 1))    \
>>     fw_def(ALDERLAKE_N,    GT_TYPE_ANY,    major_ver(i915, guc,    
>> tgl,    70, 44, 1))    \
>>     fw_def(ALDERLAKE_P,    GT_TYPE_ANY,    major_ver(i915, guc,    
>> adlp,    70, 44, 1))    \
>> -- 
>> 2.49.0
>>