From: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
To: "Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: SRIOV RPM resume lockdep issues
Date: Mon, 26 Aug 2024 12:39:57 +0000 [thread overview]
Message-ID: <3e13401972fd49240f486fd7d47580e576794c78.camel@intel.com> (raw)
Hi, Michal,
Since we want to be able to wake LNL from shrinking, I'm trying to add
lockdep annotation to verify that we don't do anything in the rpm
resume and suspend callbacks that blocks this.
However, it seems SRIOV is doing just that.
https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-137730v3/shard-adlp-6/igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all.html#dmesg-warnings39
More specifically, SRIOV grabs the xe->sriov.pf.master_lock during
rpm resume, and later is doing memory allocations under that lock, so
that a theoretical deadlock sequence could look like:
1) lock xe->sriov.pf.master_lock
2) Allocate memory
3) Enter shrinker
4) RPM resume
5) lock xe->sriov.pf.master_lock
Now, LNL has not enabled SRIOV (yet) so I can work around this for now,
but moving forward this can cause problems.
Is there a way to avoid grabbing that lock during rpm suspend / resume,
or perhaps avoid doing memory allocation under it? In this case it
appears from the trace that a bo is allocated under the lock.
Thanks,
Thomas
reply other threads:[~2024-08-26 12:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e13401972fd49240f486fd7d47580e576794c78.camel@intel.com \
--to=thomas.hellstrom@intel.com \
--cc=Michal.Wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox