From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A8B7C3ABBC for ; Mon, 12 May 2025 09:05:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 558AE10E337; Mon, 12 May 2025 09:05:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="khM/4NUN"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8157A10E01F; Mon, 12 May 2025 09:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0mTqn4uxOGOFVgmrrtw5QBIjumcsx4s7cKzF4psSG84=; b=khM/4NUNu6chJAWUOqfXhUBXkp wVljFe/6YYHOOOF9sVGWlcAN03zaMjkdH8I1wSrxuysB9fngDKMDUfg3B8F12Es7aNya1WRYb0PAk UqumuW2RbV6+bWOUeVyetFWUYjgRB61DvY4YRpf0KkyZzuSZ2VVAVkbq9WxDaoKfQgJgL1izmQ7Lj QYCMi8FRr7SXLOnu1EE97MWiCnHVzZicz0UENnCUwixSAlQzAAkyimCwOx8AaBMPOn8biv4YOLOg/ tl2IMaWRMQb8t01cCAqfvT0VN16s0UJ9MLjPAMGUG18biedrNCjtHp7SIRaVz8ZDNvSi6PpYrD+ul NlOmm+wg==; Received: from [81.79.92.254] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1uEP17-006zJx-4F; Mon, 12 May 2025 11:05:27 +0200 Message-ID: <3e884da6-62c7-4d77-b271-48d4c0ffdfbe@igalia.com> Date: Mon, 12 May 2025 10:05:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 06/13] dma-fence: Use driver and timeline name helpers internally To: =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org Cc: Sumit Semwal , Gustavo Padovan , Matthew Brost , Lucas De Marchi , Rodrigo Vivi , amd-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, kernel-dev@igalia.com References: <20250509153352.7187-1-tvrtko.ursulin@igalia.com> <20250509153352.7187-7-tvrtko.ursulin@igalia.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 12/05/2025 09:22, Christian König wrote: > On 5/9/25 17:33, Tvrtko Ursulin wrote: >> Make the implementation use the previously added helper for accessing the >> driver and timeline name. This will enable more coverage later when >> asserts will be added into them. >> >> Signed-off-by: Tvrtko Ursulin > > I would squash that together with the previous patch. Since both patches are for the same component it doesn't make much sense to separate them. > > Anyway Reviewed-by: Christian König Squashed locally and I kept your r-b. Regards, Tvrtko >> --- >> drivers/dma-buf/dma-fence.c | 9 +++++---- >> include/trace/events/dma_fence.h | 4 ++-- >> 2 files changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c >> index 33661658f684..dc2456f68685 100644 >> --- a/drivers/dma-buf/dma-fence.c >> +++ b/drivers/dma-buf/dma-fence.c >> @@ -538,8 +538,8 @@ void dma_fence_release(struct kref *kref) >> if (WARN(!list_empty(&fence->cb_list) && >> !test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags), >> "Fence %s:%s:%llx:%llx released with pending signals!\n", >> - fence->ops->get_driver_name(fence), >> - fence->ops->get_timeline_name(fence), >> + dma_fence_driver_name(fence), >> + dma_fence_timeline_name(fence), >> fence->context, fence->seqno)) { >> unsigned long flags; >> >> @@ -983,8 +983,9 @@ EXPORT_SYMBOL(dma_fence_set_deadline); >> void dma_fence_describe(struct dma_fence *fence, struct seq_file *seq) >> { >> seq_printf(seq, "%s %s seq %llu %ssignalled\n", >> - fence->ops->get_driver_name(fence), >> - fence->ops->get_timeline_name(fence), fence->seqno, >> + dma_fence_driver_name(fence), >> + dma_fence_timeline_name(fence), >> + fence->seqno, >> dma_fence_is_signaled(fence) ? "" : "un"); >> } >> EXPORT_SYMBOL(dma_fence_describe); >> diff --git a/include/trace/events/dma_fence.h b/include/trace/events/dma_fence.h >> index a4de3df8500b..84c83074ee81 100644 >> --- a/include/trace/events/dma_fence.h >> +++ b/include/trace/events/dma_fence.h >> @@ -16,8 +16,8 @@ DECLARE_EVENT_CLASS(dma_fence, >> TP_ARGS(fence), >> >> TP_STRUCT__entry( >> - __string(driver, fence->ops->get_driver_name(fence)) >> - __string(timeline, fence->ops->get_timeline_name(fence)) >> + __string(driver, dma_fence_driver_name(fence)) >> + __string(timeline, dma_fence_timeline_name(fence)) >> __field(unsigned int, context) >> __field(unsigned int, seqno) >> ), >