From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11A80CE79D2 for ; Wed, 20 Sep 2023 13:46:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEAF410E4B8; Wed, 20 Sep 2023 13:46:21 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AF1010E4B8 for ; Wed, 20 Sep 2023 13:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695217580; x=1726753580; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=3FpAQ2A/Ytgdm1eNlgXjAck0Qk+Ef0Cml+8P70vjIIE=; b=LqyXYLoiNTozMi4elv3FE/N3qWpvGCRVy4F0DBDWnSfeYCnoQJ2A6d2t RN84YFmE/7H5db6LZUFYfE4K0Qi/T3PcZSLrHp2A3kHA/wq9Kj/Eg7NDz LUI8WhInS/K8Be3WwbsEZNUWmcjghTLsdSDPo5W9TPMQkwGQFiy60Hehn IOkB3UGlRulGJ02tf5YYTAiKKN4YbHQ/Ipm9MP7Akt0q0WOhRURojm/L+ kD0rxC93o3vySXO7a61jPcNGh1kWHf8lQcIR1LWqtg3MJ0G6WIOMov8+S +Ilphqgrga9pYGtHwPt9CMhlOJhBIcJxsJi6vFZR3kYlg35uhGhNvbMPU w==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="379108211" X-IronPort-AV: E=Sophos;i="6.03,162,1694761200"; d="scan'208,217";a="379108211" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 06:46:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="723293070" X-IronPort-AV: E=Sophos;i="6.03,162,1694761200"; d="scan'208,217";a="723293070" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 06:46:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 06:46:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 06:46:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 06:46:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 06:46:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHMGEUgFXApS38t8QNPNsfki+K48YMLEOgMWeNNreBNMs1oxqGt//kua2PDnqDrK3qL0bla66E5cHeUsTwmgnCUu2GEWJe3/O6omzLM8hjC9M3Bg5pUBmktPzLzUSFeoDTBFmv7kQi5K0ARWPmrCinIz8JtatQ1EjaNFhAiIPMkJX7APmgVDhIM5IY7B0xgxEdbS5BGrf9sj9Mi1A2rOcfwEJ0zOnTdrAojEC7LkeJP1QM+csU7DCmn+o9R4g4ibR0HPOHA62/BnbuW50t6nKqQw1e56ns8LlmwKJd93O+oOQN8kzRnk170F/ESxqSeFZ1MaUnw/KUWjGZ7MhQY2bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lMAtRDanU6JS4kuvofYmo20zj9xM4q90goMFiwcCQGE=; b=g3nxE+saryUJYAcj3ArVgpZ2TXR//qidhkmeFl6X5cbb6bNQZBFpikPCCDc9tf6pBUOob74mqAjl39dVLWNaUkxD7vuFtTus67Dvy3aCQKBKNPX/XtuDsrtegFl4PXTzGjzfyxxts6nt59CZaQKPuQxkXNYYwbJKK0UrmVFrJaC/E/JnY+yFrL+xQ9I4BLKuhwaGUqkX/CymbVg0Gi/hTE+a7WPSGQEc2Ljr3nCruwcZ1pDEUmY5dr/zCoDqQe2R6bZ6FKGgQCncmKIn2GX1GEaGEkD7i7LoCSFHvxNBZsmWQA+Yra8il0yWv0lc99ysAQncu+cwXl5qkWPo5AmZiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) by LV3PR11MB8765.namprd11.prod.outlook.com (2603:10b6:408:21d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 20 Sep 2023 13:46:14 +0000 Received: from MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::82e:c2f3:6b0f:3586]) by MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::82e:c2f3:6b0f:3586%4]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023 13:46:14 +0000 Content-Type: multipart/alternative; boundary="------------GwwF22LdfXfJBnX9kXLohs3f" Message-ID: <3f3351ae-f664-4a8f-bfdc-da6508e49e6c@intel.com> Date: Wed, 20 Sep 2023 19:16:04 +0530 User-Agent: Mozilla Thunderbird To: Badal Nilawar , , References: <20230904182258.2291881-1-badal.nilawar@intel.com> <20230904182258.2291881-2-badal.nilawar@intel.com> Content-Language: en-US From: "Ghimiray, Himal Prasad" In-Reply-To: <20230904182258.2291881-2-badal.nilawar@intel.com> X-ClientProxiedBy: PN2PR01CA0210.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:e9::19) To MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB7056:EE_|LV3PR11MB8765:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ab17570-f15a-45f9-847c-08dbb9dff4fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WKQa6yTu4llDCHTnUoAZtjTGi4KPBkSzTqc7reea+0LQSQmiBJrIHDragw7Mpd+ERl2MrvFqSfMRx0FO6jqc7W+paRzhLCohPxuiQqZ1wvh6CGX2RkXKYBNjw0rmnCNVNag7EzcguoMGPLA4Fmad+YcLlTnMS9ieLdg5ZmC4aPha/H1knMFRlVdeO6RVyAB3VQ9K2GEcHrmDml00UNFgGVowDKtnzAYzhKUOPLNrgVMtiGW/NKtBZVy4H4bd1XittdEFwoM78qAZP+Ogbi6ubtAg5+1JWNhqFsGqzSLP4WWBdZqpnNNqQlRyPeN/Zqu7/KVM3F0giI7oCrGqSaWgJx2U42dcSKvBMyj9V5DE/c6Xw5akJsstspbXVDIwbdA47LxPINW3OOgIZj9Z5V3ZE0jBMFE8FQsNzqTxsv7ktE6k3/I0LkbXotMY24hmEErdHnUifP9NcSN4C4RkiVJ3FVg4KLf+KeOX5M08A7VHi3bSG0kB3/te2ASi/QbKUwhx/HP2eeONg8owTi7qgBW+MbnHBVBjGi6uoyOdXkEnr8Gh9KL/9bTaEzaDB46NlYuzeSM42iJSh9MuWPFoyGoj/APAlZih5Os95T202tatP7AImGml2xHum+z2bq7gvW0TMc3Ja1nUpS3eMLSg/jqMAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB7056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(136003)(396003)(346002)(366004)(1800799009)(186009)(451199024)(36756003)(33964004)(53546011)(6512007)(6666004)(82960400001)(6506007)(6486002)(41300700001)(4326008)(2906002)(66946007)(66556008)(31696002)(66476007)(5660300002)(8936002)(8676002)(316002)(478600001)(38100700002)(86362001)(26005)(2616005)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjdXZ2IzRDJZZUJGY1piL3lZbksrQ1hSRGl5YmVSZS9QZUxuOFBQdlc2cG1n?= =?utf-8?B?UEVNVno1N2hEd3NrVlU5OXR1TzZrN3lOU1lyeUJjSlg1WXJEYXlvOTdmejRM?= =?utf-8?B?NHVBYTZOVnJ2YTFKT3MxdmlFRUNWM3BBRDQrS2Y1YnM0aHhTbVFGYnBYS052?= =?utf-8?B?MWtDemE2UnB1NXFKYzRlM1VUKzhCM0E2RVJ5ZTZaS09NaVdQZk9XM3NROHd1?= =?utf-8?B?cmdYWEpza0d5K0ZzVDhVdGxFT2ZGOHA5L2hmM2FudFNtaEhzMURHRlRVandh?= =?utf-8?B?NGZnRkJMR2pnNmRnR0ZCT05EdWg5S1NFeXRzMDFBSWQwYmt0OXV6WDNLc3pL?= =?utf-8?B?ekZQVWl3c21JdGM4N1c1b0d1WjZMV0p4T3BKM1QvcTZrY05iZnhpNkJaeUN0?= =?utf-8?B?b2lrZ1NidHpzZUQ1RFNpZUxoUmVRUVBBSkJTMm50eUQ2cFN4TXg3eHZONVdN?= =?utf-8?B?UllIUjNiOTEwdlRwQStxbVA5T0lpT0ZYc0hJQk9ONG9iY2F1RUpYOWx3VURn?= =?utf-8?B?OVFoN0Q0MmZZSWhpaFZqa2hmZ3FpYkN0bGRQSmZ3dENPTUd0UkpBeFV3dEVo?= =?utf-8?B?Z1NwUXgrRVNzZytCSjRCK21sQVlkcld6UDhIMkZGNlU5QStlMkRwZUV3a2pC?= =?utf-8?B?dXp2UVlQVkRBcjlJUHNaanYvelgwQnlDcHhhbVc3dmlxS25GMzFaZzNjNkJj?= =?utf-8?B?Rkc1elJzLzhhTVNsWkpMNGkvVXJlQ2UxbDlrRXk5STYwNlE0K292ellQSlRC?= =?utf-8?B?cEwvYUliVTRsQjZHVmx1NXpBWVZEaElxdkM3dHJCUysyYXAwV2ZSQTBZZTF0?= =?utf-8?B?OE9ncGJ6RloxTm9FYmxlclN5WHJ0Wkovbks4aEVEdkRkZDBSYU1GWkNLU3NQ?= =?utf-8?B?Y2IvTnZmRnpwbXg4cEdJeVg2bjUyT2JzYTlLcXhVSGx3VzhQSm5CSWNqKytV?= =?utf-8?B?Ukt4VjVGODNZNkYzSDl5TGJkaGRaODZqcGQzaUFmWHI3Z3FIb2w4MFpkeldM?= =?utf-8?B?ZFk2L1oyYWFJTDFYUnRvcTRFczQ2N09sbjdpenh1S2JaNm5CUnlxRDBMUEpP?= =?utf-8?B?eDlramVCbkd5RzJLN2YvSTdEZWVjVFFqS0M5ak9BVFBUMVBqQ3F6RlZhblNO?= =?utf-8?B?RmhoZ0FDRlB0VnB4RTdPSlFNUTM1U2ZFWU1MRDJzUkIwU05ObWFlc3h1OXVK?= =?utf-8?B?dWp5WmIzbFVpTHNpZ05PMHV2aTdMc1RmWXdjTi9ZcmlYa0NlU0Z3b092b0tM?= =?utf-8?B?cTlIMGRyUUxoNlVZbTFuUEpYQkhXT3hJYmd1SFFGSktneDYxajloYkVMV05s?= =?utf-8?B?UEpKcVI4dVFBdW84M3ljekRNZ1F0cDlNZU90S2g3aXU1MjVUMTJzSjc5eldl?= =?utf-8?B?MkVXRm1CSnZjOGtHdHR4bXF0YWh6Wko1Vm5Iam9iaHgzL0hFOWk0d2dJb3hm?= =?utf-8?B?UFpNMWl2aFVyN2FzVWlTeUhkU3VlRUxtR21TUTZ4bFkyWE05Q1ptYUFic3Bw?= =?utf-8?B?UUZaQ0lORHFuUVdXS3VlbXllelRmUWx1UGlOMTZkalhzN3ZnWHdXSU5NUUdN?= =?utf-8?B?cWtiQTVhRS80YWRPU3U3cUlwWGlhRytxTHg0aHZXQ1BNR0JqSW5uMG0wdCtx?= =?utf-8?B?QWFyano5cmQyVmF3TkFLcUVZemM3NSt1ZnlGSVlJalY1R3k2MjBlQy83eFFF?= =?utf-8?B?RmtyeXFNVVo5bHMzZC9UcG93U25XUUJqZmV4R1pTU1N3a3BhOWFVaklJMTVY?= =?utf-8?B?OVFkanlFaENqZ1VPM3BuWjlXWVMvejFWWko5S2pUSXFBaW45ZmVGamMwdUNo?= =?utf-8?B?NW1OZnNKRFZpYStRYkJ0OTU5cytuODBzSThYZXhEZjNsc1hmL3l0ZTB2WWZ3?= =?utf-8?B?akdOdk4zbGkyRVo3blVGNkhRaC9GM1YzNGkwekdJZnJwd1RuZFhQdmhSK1hP?= =?utf-8?B?dUx6UjRFS2toV1gzaGYrWGJBZlVnRU5PMS9YdVYzenkyY3ZRQVVJNXV1UjZN?= =?utf-8?B?dmdsdVNJcG5XMEZXTS80KzIxUUZSQ0d4b0gyWjNuOUM3cXRHU01ncWpqaXhz?= =?utf-8?B?WmRjVzZSeWxmVzhhenZDTVN0NEZud2QvYkpURHJuTVZEUHBIS01LRFNKb01F?= =?utf-8?B?aUs3WGxGcXpQTjcrMlJ4bTB3Y0dBWFBzaHQ3M1VMUytzQ28wU1JSOVlOWDhn?= =?utf-8?Q?qcE5K4lneV8m7LLm12AD8Hc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab17570-f15a-45f9-847c-08dbb9dff4fb X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 13:46:14.5469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctIWr0g3S7Odr4gPo9KzIeqq3AFiAJZRjPzmGQjeJS422NDvA8ycTTbnOLlZ7uON28nfrvoeJMKXeDKUHS4Z1WGVGxyiOBD7U1mOiZdMcQA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8765 X-OriginatorOrg: intel.com Subject: Re: [Intel-xe] [PATCH v4 1/6] drm/xe: Add XE_MISSING_CASE macro X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux@roeck-us.net Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------GwwF22LdfXfJBnX9kXLohs3f Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 04-09-2023 23:52, Badal Nilawar wrote: > Add XE_MISSING_CASE macro to handle missing switch case > > Cc: Andi Shyti > Signed-off-by: Badal Nilawar > --- > drivers/gpu/drm/xe/xe_macros.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h > index daf56c846d03..21ba859d5f80 100644 > --- a/drivers/gpu/drm/xe/xe_macros.h > +++ b/drivers/gpu/drm/xe/xe_macros.h > @@ -15,4 +15,7 @@ > "Ioctl argument check failed at %s:%d: %s", \ > __FILE__, __LINE__, #cond), 1)) > > +#define XE_MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ > + __stringify(x), (long)(x)) Please add a comment to ensure, the parameter to macro should  be a variable name. with the above addressed: Reviewed-by: Himal Prasad Ghimiray > + > #endif --------------GwwF22LdfXfJBnX9kXLohs3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 04-09-2023 23:52, Badal Nilawar wrote:
Add XE_MISSING_CASE macro to handle missing switch case

Cc: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_macros.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h
index daf56c846d03..21ba859d5f80 100644
--- a/drivers/gpu/drm/xe/xe_macros.h
+++ b/drivers/gpu/drm/xe/xe_macros.h
@@ -15,4 +15,7 @@
 			    "Ioctl argument check failed at %s:%d: %s", \
 			    __FILE__, __LINE__, #cond), 1))
 
+#define XE_MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
+				__stringify(x), (long)(x))

Please add a comment to ensure, the parameter to macro should  be a variable name.

with the above addressed:

Reviewed-by:  Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> 
+
 #endif
--------------GwwF22LdfXfJBnX9kXLohs3f--