Re: [PATCH] drm/i915/display: Initialize phy and ch variables

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 03 Sep 2025, Mika Kahola <mika.kahola@intel.com> wrote:
> phy and ch variables are potentially used uninitialized.

They're not, bxt_port_to_phy_channel() initializes them in all code
paths.

> To make absolutely sure that these variables are not used
> uninitialized let's initialize these with known values as
> DPIO_PHY0 and DPIO_CH0, respectively.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 8ea96cc524a1..45b67a3716e9 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -2174,8 +2174,8 @@ static bool bxt_ddi_pll_get_hw_state(struct intel_display *display,
>  	struct bxt_dpll_hw_state *hw_state = &dpll_hw_state->bxt;
>  	enum port port = (enum port)pll->info->id; /* 1:1 port->PLL mapping */
>  	intel_wakeref_t wakeref;
> -	enum dpio_phy phy;
> -	enum dpio_channel ch;
> +	enum dpio_phy phy = DPIO_PHY0;
> +	enum dpio_channel ch = DPIO_CH0;
>  	u32 val;
>  	bool ret;

-- 
Jani Nikula, Intel