From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rahul Bukte <rahul.bukte@sony.com>, Tvrtko Ursulin <tursulin@igalia.com>
Cc: Suraj Kandpal <suraj.kandpal@intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/gt: Check set_default_submission() before deferencing
Date: Wed, 18 Mar 2026 11:41:38 +0200 [thread overview]
Message-ID: <407885d79847863026260d4f911e905da8d51724@intel.com> (raw)
In-Reply-To: <abo9bv1oz_5S66zE@rahul-Z690-S01>
On Wed, 18 Mar 2026, Rahul Bukte <rahul.bukte@sony.com> wrote:
> Hi,
>
> On Fri, Mar 13, 2026 at 06:34:22PM +0200, Jani Nikula wrote:
>> On Tue, 03 Feb 2026, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
>> > From: Rahul Bukte <rahul.bukte@sony.com>
>> >
>> > When the i915 driver firmware binaries are not present, the
>> > set_default_submission pointer is not set. This pointer is
>> > dereferenced during suspend anyways.
>>
>> Which kernel vesions did this happen with? Should this have had Fixes:
>> or Cc: stable?
>
> Fixes: ff44ad51ebf8 ("drm/i915: Move engine->submit_request selection to a vfunc")
> Cc: stable@vger.kernel.org
>
> Suraj, you mentioned that you have commited this to din [1]. Can we add
> this fixes and cc tags to that please?
>
> [1]: https://lore.kernel.org/all/DM3PPF208195D8D000253F905FADCA379F9E36DA@DM3PPF208195D8D.namprd11.prod.outlook.com/
Tvrtko, please pick this up for drm-intel-fixes.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-03-18 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 4:48 [PATCH] drm/i915/gt: Check set_default_submission() before deferencing Suraj Kandpal
2026-02-03 8:49 ` ✗ CI.checkpatch: warning for drm/i915/gt: Check set_default_submission() before deferencing (rev2) Patchwork
2026-02-03 8:51 ` ✓ CI.KUnit: success " Patchwork
2026-02-03 9:34 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-03 22:03 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-17 5:57 ` [PATCH] drm/i915/gt: Check set_default_submission() before deferencing Kandpal, Suraj
2026-03-13 16:34 ` Jani Nikula
2026-03-18 5:51 ` Rahul Bukte
2026-03-18 9:41 ` Jani Nikula [this message]
[not found] <20260115015454.3226069-1-rahul.bukte@sony.com>
2026-02-03 4:47 ` Suraj Kandpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407885d79847863026260d4f911e905da8d51724@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rahul.bukte@sony.com \
--cc=suraj.kandpal@intel.com \
--cc=tursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox