From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3864CE98E13 for ; Mon, 23 Feb 2026 10:32:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE16D10E329; Mon, 23 Feb 2026 10:32:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CqT3re6m"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BE7C10E2E3; Mon, 23 Feb 2026 10:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771842751; x=1803378751; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Htf6QYSoKh0Dp23x9Bfd5uue58QzBD543bJ74cClME0=; b=CqT3re6m7okfvB3MNzKMMDmhGJ4itZ4rtPTfV9OtdKuIK3xqSOzCuWnC 3lI9MIIjip0EGThy0Hbi/mOkB0RASVHUEiSKlKjHsj8WDzOWN4Ti4DhBd WazsMhMUYVMQ3/YmRwda+J0Sg/ZoVdx1nM+6H+4R5ZyAdDpHKLfb1fHRT LB/NLOs//kilwddi9ryJsaismFH5kt4FNjz0jHhz785gyPZPaynNKU2So C3Eo1TAkfL5wYUg3vB1tKyhE0phFedn74sp2EH8bpVJtXCdB9+fyIPdzV b5mp1EFHPv9isrNFZNn5wxv6uMT2SUyZniOREFdbJdsqEiJLbblJao6vM A==; X-CSE-ConnectionGUID: 1F/Q0+9tQCu9N46Nx3ZAvA== X-CSE-MsgGUID: iUiYwWwoQSuDXNGaJX3LuA== X-IronPort-AV: E=McAfee;i="6800,10657,11709"; a="83459421" X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="83459421" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 02:32:30 -0800 X-CSE-ConnectionGUID: JRrssEptQBmXmSDZsmXJRg== X-CSE-MsgGUID: ZfC1fTF0S7mFN1OUm4sgyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="219638484" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.246.249]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 02:32:29 -0800 From: Jani Nikula To: Vidya Srinivas , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, Vidya Srinivas Subject: Re: [PATCH] drm/displayid: reduce DisplayID checksum error logging to debug In-Reply-To: <20260217055002.245099-1-vidya.srinivas@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260217055002.245099-1-vidya.srinivas@intel.com> Date: Mon, 23 Feb 2026 12:32:25 +0200 Message-ID: <40f54d2357194813cd16e71a49b719f8c35b1549@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 17 Feb 2026, Vidya Srinivas wrote: > The patch "drm/displayid: add quirk to ignore DisplayID > checksum errors" introduced a mechanism to bypass checksum validation > for certain panels. However, even when ignoring the error, the code > continues to log a DRM_NOTE. Please refer to commits with the usual format (see git log). > On affected hardware, this results in persistent "DisplayID checksum > invalid" messages in the system log. This noise often misleads users > into thinking there is a critical hardware failure or a functional > regression, despite the quirk successfully handling the issue. > > Downgrade the log level from DRM_NOTE to DRM_DEBUG_KMS. This keeps > the diagnostic information available for kernel developers while > silencing the unnecessary warning for end-users. > > Signed-off-by: Vidya Srinivas > --- > drivers/gpu/drm/drm_displayid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_displayid.c b/drivers/gpu/drm/drm_displayid.c > index 58d0bb6d2676..1f6d78fe29f2 100644 > --- a/drivers/gpu/drm/drm_displayid.c > +++ b/drivers/gpu/drm/drm_displayid.c > @@ -69,7 +69,7 @@ validate_displayid(const u8 *displayid, int length, int idx, bool ignore_checksu > for (i = 0; i < dispid_length; i++) > csum += displayid[idx + i]; > if (csum) { > - DRM_NOTE("DisplayID checksum invalid, remainder is %d%s\n", csum, > + DRM_DEBUG_KMS("DisplayID checksum invalid, remainder is %d%s\n", csum, > ignore_checksum ? " (ignoring)" : ""); I understand the desire to make it debug level with the quirk, but IMO it needs to be more than debug level when there is no quirk. BR, Jani. > > if (!ignore_checksum) -- Jani Nikula, Intel