Re: [PATCH] drm/xe: Add caller info to xe_gt_reset_async

[Nirmoy Das <nirmoy.das@intel.com>]

On 10/16/2024 4:44 PM, Matthew Auld wrote:
> On 16/10/2024 14:44, Nirmoy Das wrote:
>> Add caller info to the xe_gt_reset_async() to help debug issues.
>>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2874
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_gt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>> index 1c79660fb086..51324c7da0a9 100644
>> --- a/drivers/gpu/drm/xe/xe_gt.c
>> +++ b/drivers/gpu/drm/xe/xe_gt.c
>> @@ -834,7 +834,7 @@ static void gt_reset_worker(struct work_struct *w)
>>     void xe_gt_reset_async(struct xe_gt *gt)
>>   {
>> -    xe_gt_info(gt, "trying reset\n");
>> +    xe_gt_info(gt, "trying reset from %pS\n", __builtin_return_address(0));
>
> Probably ps is verbose enough?

Yes, that will work too. Re-sending.


Thanks,

Nirmoy

>
>>         /* Don't do a reset while one is already in flight */
>>       if (!xe_fault_inject_gt_reset() && xe_uc_reset_prepare(&gt->uc))