Re: [PATCH v10 1/1] drm/i915/display: Add no_psr_reason to PSR debugfs

["michal.grzelak" <mgrzelak@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Mon, 15 Sep 2025, Hogander, Jouni wrote:

> On Wed, 2025-09-03 at 12:31 +0200, Michał Grzelak wrote:
>> There is no reason in debugfs why PSR has been disabled. Currently,
>> without this information, IGT tests cannot decide whether PSR has
>> been disabled on purpose or was it abnormal behavior. Because of it,
>> the status of the test cannot be decided correctly.
>>
>> Add no_psr_reason field into struct intel_psr. Add no_psr_reason
>> into struct intel_crtc_state to prevent staying out of sync when
>> _psr_compute_config is not using computed state. Write the reason,
>> e.g. PSR setup timing not met, into proper PSR debugfs file. Update
>> the reason from old_crtc_state in intel_psr_pre_plane_update. Extend
>> format of debugfs file to have reason when it is non-NULL. Clean the
>> reason when PSR is activated.
>>
>> Refactor intel_psr_post_plane_update to use no_psr_reason along
>> keep_disabled.
>> [...]
>> @@ -2922,6 +2924,9 @@ void intel_psr_pre_plane_update(struct
>> intel_atomic_state *state,
>>  
>>  		mutex_lock(&psr->lock);
>>  
>> +		if (!new_crtc_state->has_psr)
>> +			psr->no_psr_reason = old_crtc_state-
>>> no_psr_reason;
>
> I think you should use new_crtc_state->no_psr_reason.
>
Right, thanks for picking that. Will fix it in next version.

BR,
Michał