From: Johannes Berg <johannes@sipsolutions.net>
To: "José Roberto de Souza" <jose.souza@intel.com>,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Mukesh Ojha <quic_mojha@quicinc.com>,
Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: Re: [PATCH v3 1/4] devcoredump: Add dev_coredump_put()
Date: Mon, 25 Mar 2024 17:48:09 +0100 [thread overview]
Message-ID: <4aa1f6ae3ac72a5eb3303740242d53d46a338d6b.camel@sipsolutions.net> (raw)
In-Reply-To: <20240304143905.52740-1-jose.souza@intel.com>
On Mon, 2024-03-04 at 06:39 -0800, José Roberto de Souza wrote:
> It is useful for modules that do not want to keep coredump available
> after its unload.
Why not though? Maybe if this is a common case we should have devm_...
coredump functions? Dunno.
Anyway, I'm fine with this, even though I'd like to see a bit more
discussion than "do not want". Code looks good.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2024-03-25 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 14:39 [PATCH v3 1/4] devcoredump: Add dev_coredump_put() José Roberto de Souza
2024-03-04 14:39 ` [PATCH v3 2/4] devcoredump: Add dev_coredumpm_timeout() José Roberto de Souza
2024-03-04 23:56 ` Lucas De Marchi
2024-03-11 20:56 ` Souza, Jose
2024-03-25 17:00 ` Johannes Berg
2024-03-25 18:28 ` Souza, Jose
2024-03-04 14:39 ` [PATCH v3 3/4] drm/xe: Remove devcoredump during driver release José Roberto de Souza
2024-03-04 14:39 ` [PATCH v3 4/4] drm/xe: Increase devcoredump timeout José Roberto de Souza
2024-03-04 14:47 ` ✓ CI.Patch_applied: success for series starting with [v3,1/4] devcoredump: Add dev_coredump_put() Patchwork
2024-03-04 14:48 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-04 14:49 ` ✓ CI.KUnit: success " Patchwork
2024-03-04 14:59 ` ✓ CI.Build: " Patchwork
2024-03-04 15:00 ` ✓ CI.Hooks: " Patchwork
2024-03-04 15:02 ` ✓ CI.checksparse: " Patchwork
2024-03-04 15:26 ` ✓ CI.BAT: " Patchwork
2024-03-25 16:48 ` Johannes Berg [this message]
2024-03-25 18:36 ` [PATCH v3 1/4] " Souza, Jose
2024-04-05 15:47 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aa1f6ae3ac72a5eb3303740242d53d46a338d6b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=jose.souza@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox