Re: [PATCH v5 1/6] drm/xe/uapi: Add additional error components to xe drm_ras

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 04-05-2026 12:26 pm, Riana Tauro wrote:
> Add additional Error components supported by XE drm_ras (Reliability,
> Availability and Serviceability).
>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>
> ---
>   include/uapi/drm/xe_drm.h | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 48e9f1fdb78d..50c80af4ad4e 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -2589,6 +2589,12 @@ enum drm_xe_ras_error_component {
>   	DRM_XE_RAS_ERR_COMP_CORE_COMPUTE = 1,
>   	/** @DRM_XE_RAS_ERR_COMP_SOC_INTERNAL: SoC Internal Error */
>   	DRM_XE_RAS_ERR_COMP_SOC_INTERNAL,
> +	/** @DRM_XE_RAS_ERR_COMP_DEVICE_MEMORY: Device Memory Error */
> +	DRM_XE_RAS_ERR_COMP_DEVICE_MEMORY,
> +	/** @DRM_XE_RAS_ERR_COMP_PCIE: PCIe Subsystem Error */
> +	DRM_XE_RAS_ERR_COMP_PCIE,
> +	/** @DRM_XE_RAS_ERR_COMP_FABRIC: Fabric Subsystem Error */
> +	DRM_XE_RAS_ERR_COMP_FABRIC,
>   	/** @DRM_XE_RAS_ERR_COMP_MAX: Max Error */
>   	DRM_XE_RAS_ERR_COMP_MAX	/* non-ABI */
>   };
> @@ -2606,7 +2612,10 @@ enum drm_xe_ras_error_component {
>    */
>   #define DRM_XE_RAS_ERROR_COMPONENT_NAMES {				\
>   	[DRM_XE_RAS_ERR_COMP_CORE_COMPUTE] = "core-compute",		\
> -	[DRM_XE_RAS_ERR_COMP_SOC_INTERNAL] = "soc-internal"		\
> +	[DRM_XE_RAS_ERR_COMP_SOC_INTERNAL] = "soc-internal",		\
> +	[DRM_XE_RAS_ERR_COMP_DEVICE_MEMORY] = "device-memory",		\
> +	[DRM_XE_RAS_ERR_COMP_PCIE] = "pcie",				\
> +	[DRM_XE_RAS_ERR_COMP_FABRIC] = "fabric",			\
>   }

Please add static assert check to keep names in sync.

With that addressed:

Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

Thanks,

-/Mallesh

>   
>   #if defined(__cplusplus)