From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Subject: RE: [PATCH v2 1/8] drm/i915: move SKL clock gating init to display
Date: Tue, 07 Apr 2026 10:58:13 +0300 [thread overview]
Message-ID: <4c2ab7b05e665b3cca5a809917faf3b64d1ce7f5@intel.com> (raw)
In-Reply-To: <DM3PPF208195D8D6D18797DF43D23B2AB3DE35AA@DM3PPF208195D8D.namprd11.prod.outlook.com>
On Tue, 07 Apr 2026, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> +void intel_display_skl_init_clock_gating(struct intel_display *display)
>> +{
>> + /*
>> + * WaFbcTurnOffFbcWatermark:skl
>> + * Display WA #0562: skl
>> + */
>> + intel_de_rmw(display, DISP_ARB_CTL, 0, DISP_FBC_WM_DIS); }
>
> Not sure about this being moved here but I feel like this belong in
> intel_display_wa.c see that it is a WA
A lot of intel_clock_gating.c is about workarounds, and I don't really
care a whole lot about moving these to intel_display_wa.c at this
point. It's much more important to move the display related things from
i915 core to display.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-04-07 7:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 12:07 [PATCH v2 0/8] drm/i915: move more display dependencies from i915 Luca Coelho
2026-03-31 12:07 ` [PATCH v2 1/8] drm/i915: move SKL clock gating init to display Luca Coelho
2026-04-07 2:51 ` Kandpal, Suraj
2026-04-07 7:58 ` Jani Nikula [this message]
2026-04-07 9:47 ` Ville Syrjälä
2026-04-07 9:51 ` Jani Nikula
2026-03-31 12:07 ` [PATCH v2 2/8] drm/i915: move KBL " Luca Coelho
2026-03-31 12:07 ` [PATCH v2 3/8] drm/i915/display: move CFL " Luca Coelho
2026-03-31 12:07 ` [PATCH v2 4/8] drm/i915/display: move BXT " Luca Coelho
2026-03-31 12:07 ` [PATCH v2 5/8] drm/i915/display: move GLK " Luca Coelho
2026-03-31 12:55 ` Jani Nikula
2026-03-31 12:07 ` [PATCH v2 6/8] drm/i915/display: move HSW and BDW " Luca Coelho
2026-03-31 12:07 ` [PATCH v2 7/8] drm/i915/display: move pre-HSW " Luca Coelho
2026-03-31 12:57 ` Jani Nikula
2026-03-31 12:07 ` [PATCH v2 8/8] drm/i915: remove HAS_PCH_NOP() dependency from clock gating Luca Coelho
2026-04-02 7:04 ` ✗ CI.checkpatch: warning for drm/i915: move more display dependencies from i915 (rev2) Patchwork
2026-04-02 7:05 ` ✓ CI.KUnit: success " Patchwork
2026-04-02 7:55 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-02 13:10 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2ab7b05e665b3cca5a809917faf3b64d1ce7f5@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=luciano.coelho@intel.com \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox