From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, uma.shankar@intel.com,
Vidya Srinivas <vidya.srinivas@intel.com>,
Charlton Lin <charlton.lin@intel.com>
Subject: Re: [PATCH v3] drm/i915/display: Limit scaler count and disable pipe joiner on WCL
Date: Tue, 27 Oct 2026 13:14:02 +0200 [thread overview]
Message-ID: <4ce16eb36f580b8e1f7b71d9555bf6c0cbd8a3bd@intel.com> (raw)
In-Reply-To: <20261027043335.1906466-1-vidya.srinivas@intel.com>
On Tue, 27 Oct 2026, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> Pipe joining is not supported in the WCL display configuration.
> Modes that would require joining are rejected, matching the
> 4k 60Hz maximum resolution documented for the platform.
>
> Also, WCL support single pipe scaler instead of two.
One change per patch, please. The changes are functionally unrelated.
> Bspec: 74286
Git commit trailers go together with no blank lines in between...
> v2: Rebase onto latest upstream
...and certainly not the changelog in between. And v3 changes are
missing.
> Suggested-by: Charlton Lin <charlton.lin@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_device.c | 5 ++++-
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index f17fc2c68472..c74256359c25 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -1813,7 +1813,10 @@ static void __intel_display_device_info_runtime_init(struct intel_display *displ
> if (intel_display_wa(display, INTEL_DISPLAY_WA_14011765242))
> for_each_pipe(display, pipe)
> display_runtime->num_scalers[pipe] = 0;
> - else if (DISPLAY_VER(display) >= 11) {
> + else if (DISPLAY_VERx100(display) == 3002) {
> + for_each_pipe(display, pipe)
> + display_runtime->num_scalers[pipe] = 1;
> + } else if (DISPLAY_VER(display) >= 11) {
> for_each_pipe(display, pipe)
> display_runtime->num_scalers[pipe] = 2;
> } else if (DISPLAY_VER(display) >= 9) {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 00e02e019d25..ef164a797618 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -485,9 +485,9 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp)
> return false;
> }
>
> - return DISPLAY_VER(display) >= 12 ||
> + return ((DISPLAY_VER(display) >= 12 && DISPLAY_VERx100(display) != 3002) ||
> (DISPLAY_VER(display) == 11 &&
> - encoder->port != PORT_A);
> + encoder->port != PORT_A));
> }
>
> static int dg2_max_source_rate(struct intel_dp *intel_dp)
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-10-27 11:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 7:23 [PATCH] drm/i915/display: Limit scaler count and disable pipe joiner on WCL Vidya Srinivas
2026-10-07 8:00 ` ✓ CI.KUnit: success for " Patchwork
2026-10-07 8:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-07 9:59 ` ✓ Xe.CI.FULL: " Patchwork
2026-10-15 8:25 ` [PATCH] " Shankar, Uma
2026-10-15 8:28 ` Srinivas, Vidya
2026-10-27 4:28 ` [PATCH v2] " Vidya Srinivas
2026-10-27 4:33 ` [PATCH v3] " Vidya Srinivas
2026-10-27 11:14 ` Jani Nikula [this message]
2026-10-27 11:57 ` Srinivas, Vidya
2026-10-27 4:45 ` ✗ CI.checkpatch: warning for drm/i915/display: Limit scaler count and disable pipe joiner on WCL (rev2) Patchwork
2026-10-27 4:47 ` ✓ CI.KUnit: success " Patchwork
2026-10-27 5:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-27 5:27 ` ✓ CI.KUnit: success for drm/i915/display: Limit scaler count and disable pipe joiner on WCL (rev3) Patchwork
2026-10-27 6:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-27 9:18 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-28 7:04 ` [PATCH v4 0/2] drm/i915/display: Limit scaler count and disable pipe joiner on WCL Vidya Srinivas
2026-10-28 7:04 ` [PATCH v4 1/2] drm/i915/display: Single scaler per pipe " Vidya Srinivas
2026-10-28 15:58 ` Srinivas, Vidya
2026-10-28 16:56 ` Srinivas, Vidya
2026-10-28 7:04 ` [PATCH v4 2/2] drm/i915/display: Disable pipe joiner " Vidya Srinivas
2026-10-28 8:38 ` Borah, Chaitanya Kumar
2026-10-28 8:57 ` Srinivas, Vidya
2026-10-28 9:28 ` Borah, Chaitanya Kumar
2026-10-28 9:37 ` Borah, Chaitanya Kumar
2026-10-28 9:59 ` Srinivas, Vidya
2026-10-28 10:33 ` Jani Nikula
2026-10-28 15:59 ` Srinivas, Vidya
2026-10-28 16:56 ` Srinivas, Vidya
2026-10-29 11:23 ` [PATCH v4 0/2] drm/i915/display: Limit scaler count and disable " Shankar, Uma
2026-10-28 7:20 ` ✗ CI.checkpatch: warning for drm/i915/display: Limit scaler count and disable pipe joiner on WCL (rev4) Patchwork
2026-10-28 7:22 ` ✓ CI.KUnit: success " Patchwork
2026-10-28 7:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-28 12:46 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ce16eb36f580b8e1f7b71d9555bf6c0cbd8a3bd@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=charlton.lin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox