Re: [PATCH] drm/i915/display/xe3lpd: Avoid setting YUV420_MODE in PIPE_MISC

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 11/18/2024 7:14 PM, Juha-Pekka Heikkilä wrote:
> These display patches probably should go through i915 ci also since it
> changes code on i915.
>
> patch itself look ok,
>
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Was already tested with i915 CI.

Patch is pushed to drm-intel-next. Thanks JP for the review.


Regards,

Ankit

>
> On Wed, Nov 13, 2024 at 1:53 PM Ankit Nautiyal
> <ankit.k.nautiyal@intel.com> wrote:
>> For Xe3_LPD the PIPE_MISC YUV420 Enable (bit 27), already implies enabling
>> full blend YUV420 mode and YUV420 Mode (bit 26) is removed.
>> Therefore, avoid setting YUV420 Mode for Xe3_LPD+ while programming
>> PIPE_MISC for YCbCr420 output format.
>>
>> Bspec: 69749
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_display.c | 15 ++++++++++-----
>>   1 file changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index e790a2de5b3d..9db255bb1230 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -3137,9 +3137,14 @@ bdw_get_pipe_misc_output_format(struct intel_crtc *crtc)
>>          tmp = intel_de_read(dev_priv, PIPE_MISC(crtc->pipe));
>>
>>          if (tmp & PIPE_MISC_YUV420_ENABLE) {
>> -               /* We support 4:2:0 in full blend mode only */
>> -               drm_WARN_ON(&dev_priv->drm,
>> -                           (tmp & PIPE_MISC_YUV420_MODE_FULL_BLEND) == 0);
>> +               /*
>> +                * We support 4:2:0 in full blend mode only.
>> +                * For xe3_lpd+ this is implied in YUV420 Enable bit.
>> +                * Ensure the same for prior platforms in YUV420 Mode bit.
>> +                */
>> +               if (DISPLAY_VER(dev_priv) < 30)
>> +                       drm_WARN_ON(&dev_priv->drm,
>> +                                   (tmp & PIPE_MISC_YUV420_MODE_FULL_BLEND) == 0);
>>
>>                  return INTEL_OUTPUT_FORMAT_YCBCR420;
>>          } else if (tmp & PIPE_MISC_OUTPUT_COLORSPACE_YUV) {
>> @@ -3388,8 +3393,8 @@ static void bdw_set_pipe_misc(struct intel_dsb *dsb,
>>                  val |= PIPE_MISC_OUTPUT_COLORSPACE_YUV;
>>
>>          if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420)
>> -               val |= PIPE_MISC_YUV420_ENABLE |
>> -                       PIPE_MISC_YUV420_MODE_FULL_BLEND;
>> +               val |= DISPLAY_VER(display) >= 30 ? PIPE_MISC_YUV420_ENABLE :
>> +                       PIPE_MISC_YUV420_ENABLE | PIPE_MISC_YUV420_MODE_FULL_BLEND;
>>
>>          if (DISPLAY_VER(dev_priv) >= 11 && is_hdr_mode(crtc_state))
>>                  val |= PIPE_MISC_HDR_MODE_PRECISION;
>> --
>> 2.45.2
>>