Re: [PATCH v3 4/6] drm/xe/xe_ras: Add function to get maximum pages firmware can store

["Tauro, Riana" <riana.tauro@intel.com>]

On 01-10-2026 17:06, Upadhyay, Tejas wrote:
>
>> -----Original Message-----
>> From: Tauro, Riana <riana.tauro@intel.com>
>> Sent: 28 September 2026 11:49
>> To: intel-xe@lists.freedesktop.org
>> Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
>> <anshuman.gupta@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
>> aravind.iddamsetty@linux.intel.com; Nilawar, Badal
>> <badal.nilawar@intel.com>; Jadav, Raag <raag.jadav@intel.com>;
>> Koppuravuri, Ravi Kishore <ravi.kishore.koppuravuri@intel.com>; Koujalagi,
>> Mallesh <mallesh.koujalagi@intel.com>; Upadhyay, Tejas
>> <tejas.upadhyay@intel.com>; Ghimiray, Himal Prasad
>> <himal.prasad.ghimiray@intel.com>
>> Subject: [PATCH v3 4/6] drm/xe/xe_ras: Add function to get maximum pages
>> firmware can store
>>
>> Add function to get maximum number of pages that firmware can store for
>> offline tracking. This will be used to report max pages to userspace.
>>
>> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
>> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>> ---
>> v2: fix commit message (Himal)
>> ---
>>   drivers/gpu/drm/xe/xe_ras.c       | 15 +++++++++++++++
>>   drivers/gpu/drm/xe/xe_ras.h       |  1 +
>>   drivers/gpu/drm/xe/xe_ras_types.h |  2 ++
>>   3 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c index
>> 9a1a8190578b..cfc7f07e9ced 100644
>> --- a/drivers/gpu/drm/xe/xe_ras.c
>> +++ b/drivers/gpu/drm/xe/xe_ras.c
>> @@ -401,9 +401,13 @@ static void get_offlined_list(struct xe_device *xe)  {
>>   	struct xe_ras_offline_list_response response = {0};
>>   	struct xe_ras_offline_list_request request = {0};
>> +	struct xe_ras_state *state = &xe->ras.state;
>>
>>   	get_offline_pages(xe, XE_SYSCTRL_CMD_GET_OFFLINE_LIST,
>> &request, sizeof(request),
>>   			  &response, sizeof(response), &response.common,
>> false);
> Isnt it better to  snapshot max_entries into a local in get_offlined_list() as soon as the first response comes back, not after the whole paginated fetch completes. I mean better to not depend on "whatever's left in resp when the function returns."

yeah i am adding this for next rev. The last response can be 0s cannot 
be guarantee to have max entries

Thanks
Riana

>   
> Tejas
>> +
>> +	if (response.max_entries)
>> +		state->max_pages = response.max_entries;
>>   }
>>
>>   static struct pci_dev *find_usp_dev(struct pci_dev *pdev) @@ -1105,6
>> +1109,17 @@ bool xe_ras_get_disable_page_offline(struct xe_device *xe)
>>   	return xe->ras.state.disable_page_offline;
>>   }
>>
>> +/**
>> + * xe_ras_get_max_pages - Get the maximum number of pages
>> + * @xe: xe device instance
>> + *
>> + * Return: Maximum number of pages that can be stored in flash  */
>> +u32 xe_ras_get_max_pages(struct xe_device *xe) {
>> +	return xe->ras.state.max_pages;
>> +}
>> +
>>   /**
>>    * xe_ras_init - Initialize Xe RAS
>>    * @xe: xe device instance
>> diff --git a/drivers/gpu/drm/xe/xe_ras.h b/drivers/gpu/drm/xe/xe_ras.h index
>> ac1253d6ead9..561c656e2ad3 100644
>> --- a/drivers/gpu/drm/xe/xe_ras.h
>> +++ b/drivers/gpu/drm/xe/xe_ras.h
>> @@ -22,5 +22,6 @@ int xe_ras_set_threshold(struct xe_device *xe, u8
>> severity, u8 component, u32 th  void xe_ras_init(struct xe_device *xe);  enum
>> xe_ras_recovery_action xe_ras_process_errors(struct xe_device *xe);  bool
>> xe_ras_get_disable_page_offline(struct xe_device *xe);
>> +u32 xe_ras_get_max_pages(struct xe_device *xe);
>>
>>   #endif
>> diff --git a/drivers/gpu/drm/xe/xe_ras_types.h
>> b/drivers/gpu/drm/xe/xe_ras_types.h
>> index 40224db38906..e09b50a6f77b 100644
>> --- a/drivers/gpu/drm/xe/xe_ras_types.h
>> +++ b/drivers/gpu/drm/xe/xe_ras_types.h
>> @@ -415,5 +415,7 @@ struct xe_ras_set_health_response {  struct
>> xe_ras_state {
>>   	/** @disable_page_offline: cached configfs policy, immutable after init
>> */
>>   	bool disable_page_offline;
>> +	/** @max_pages: Total number of pages that can be stored by
>> firmware */
>> +	u32 max_pages;
>>   };
>>   #endif
>> --
>> 2.47.1