From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D774DC52D6F for ; Tue, 27 Aug 2024 06:54:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76BB710E297; Tue, 27 Aug 2024 06:54:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="V7QSNOFn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FPb6yIgK"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="V7QSNOFn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FPb6yIgK"; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D43110E297; Tue, 27 Aug 2024 06:54:34 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F1DEB21AF8; Tue, 27 Aug 2024 06:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724741673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=giPvPx5Q49oVDT0Zi/A4xSlGRTcdYaHOBuSaEFtOay0=; b=V7QSNOFnaDTvfT36NvCE6sdiClEZg6kMPaujlQqNMdUdWWL8zQGPna4LJf/Yg2lpOkzYcB 1byw23mB0v+0M9YZWku0f8fXyAgIUBTcp212F/Spq9f2IB3lva0cd5DX16c4MPMiTD7UtM FDnertu7U6Fw+L0fyiMCQfXb+Ze/4Kk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724741673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=giPvPx5Q49oVDT0Zi/A4xSlGRTcdYaHOBuSaEFtOay0=; b=FPb6yIgKPbsmwJ0n4A1SE/l5xjtNiNjltqmaa3pKFGn4PX4jgkzt5bXUK48+h85RV1eVnF quHeAsvL6W2tesAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=V7QSNOFn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FPb6yIgK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724741673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=giPvPx5Q49oVDT0Zi/A4xSlGRTcdYaHOBuSaEFtOay0=; b=V7QSNOFnaDTvfT36NvCE6sdiClEZg6kMPaujlQqNMdUdWWL8zQGPna4LJf/Yg2lpOkzYcB 1byw23mB0v+0M9YZWku0f8fXyAgIUBTcp212F/Spq9f2IB3lva0cd5DX16c4MPMiTD7UtM FDnertu7U6Fw+L0fyiMCQfXb+Ze/4Kk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724741673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=giPvPx5Q49oVDT0Zi/A4xSlGRTcdYaHOBuSaEFtOay0=; b=FPb6yIgKPbsmwJ0n4A1SE/l5xjtNiNjltqmaa3pKFGn4PX4jgkzt5bXUK48+h85RV1eVnF quHeAsvL6W2tesAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A28BC13724; Tue, 27 Aug 2024 06:54:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WPIOJih4zWZ8bwAAD6G6ig (envelope-from ); Tue, 27 Aug 2024 06:54:32 +0000 Message-ID: <4f4109db-17af-45db-8bbf-86afd9868dcd@suse.de> Date: Tue, 27 Aug 2024 08:54:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/xe: Support 'nomodeset' kernel command-line option To: Lucas De Marchi Cc: Jani Nikula , Gustavo Sousa , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <20240821135750.102117-1-tzimmermann@suse.de> <172424976000.2071.18125280900868355577@gjsousa-mobl2> <87plq23q6m.fsf@intel.com> <35a03177-28a8-4d8f-9e56-d48298a4edab@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F1DEB21AF8 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[linux.intel.com,intel.com,gmail.com,ffwll.ch,kernel.org,lists.freedesktop.org]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email, suse.de:dkim, suse.de:mid, suse.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Am 27.08.24 um 05:59 schrieb Lucas De Marchi: > On Wed, Aug 21, 2024 at 04:48:23PM GMT, Thomas Zimmermann wrote: >> Hi >> >> Am 21.08.24 um 16:29 schrieb Jani Nikula: >>> On Wed, 21 Aug 2024, Gustavo Sousa wrote: >>>> Quoting Thomas Zimmermann (2024-08-21 10:56:59-03:00) >>>>> Setting 'nomodeset' on the kernel command line disables all graphics >>>>> drivers with modesetting capabilities; leaving only firmware drivers, >>>>> such as simpledrm or efifb. >>>>> >>>>> Most DRM drivers automatically support 'nomodeset' via DRM's module >>>>> helper macros. In xe, which uses regular module_init(), manually call >>>>> drm_firmware_drivers_only() to test for 'nomodeset'. Do not register >>>>> the driver if set. >>>>> >>>>> Signed-off-by: Thomas Zimmermann >>>>> --- >>>>> drivers/gpu/drm/xe/xe_module.c | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/xe/xe_module.c >>>>> b/drivers/gpu/drm/xe/xe_module.c >>>>> index 923460119cec..60fb7dd26903 100644 >>>>> --- a/drivers/gpu/drm/xe/xe_module.c >>>>> +++ b/drivers/gpu/drm/xe/xe_module.c >>>>> @@ -8,6 +8,8 @@ >>>>> #include >>>>> #include >>>>> >>>>> +#include >>>>> + >>>>> #include "xe_drv.h" >>>>> #include "xe_hw_fence.h" >>>>> #include "xe_pci.h" >>>>> @@ -92,6 +94,9 @@ static int __init xe_init(void) >>>>> { >>>>>         int err, i; >>>>> >>>>> +        if (drm_firmware_drivers_only()) >>>>> +                return -ENODEV; >>>>> + >>>> Hm... But what if xe is to be used only for compute or render? >>>> Shouldn't >>>> we handle this somewhere else? >>> The question becomes, what does "nomodeset" really mean here? >> >> That function's name 'firmware drivers only' says it better than the >> option's name. We used 'nomodeset', because it was there already and >> had the correct semantics. > > agreed this should be on a module-level to maintain the behavior already > used. If we were not maintaining that behavior, then we should probably > not use "nomodeset" and choose something else :). > > Also we already have the other 2 as module params:  probe_display and > disable_display, with driver still registering as a drm driver, but > leaving the display part out. > > Thomas, are you going to send a v2 to use the init table? Sure, in a bit. Best regards Thomas > > thanks > Lucas De Marchi > >> >>> >>> See what i915 does in i915_module.c. >> >> i915 and the other drivers for PCI-based hardware don't load at all. >> Drivers for external displays (e.g., SPI, USB) ignore nomodeset, as >> these displays are not initialized by firmware. >> >> Best regards >> Thomas >> >>> >>> Cc: Sima. >>> >>> BR, >>> Jani. >>> >>> >>> >>>> Taking a quick look, xe_display_probe() might be a good candidate? >>>> >>>> -- >>>> Gustavo Sousa >>>> >>>>>         for (i = 0; i < ARRAY_SIZE(init_funcs); i++) { >>>>>                 err = init_funcs[i].init(); >>>>>                 if (err) { >>>>> -- >>>>> 2.46.0 >>>>> >> >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstrasse 146, 90461 Nuernberg, Germany >> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman >> HRB 36809 (AG Nuernberg) >> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)