From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-xe@lists.freedesktop.org
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH v2 3/4] drm/xe: Reword exec_queue.lock doc
Date: Wed, 30 Oct 2024 10:28:51 +0100 [thread overview]
Message-ID: <4f4a5fe8-fb47-4429-94e3-815da323c5b2@linux.intel.com> (raw)
In-Reply-To: <20241029214351.776293-4-lucas.demarchi@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On 10/29/2024 10:43 PM, Lucas De Marchi wrote:
> Reword documentation to possibly what it meant to be.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_device_types.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 85bede4dd6461..ef7412d653d2e 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -597,7 +597,7 @@ struct xe_file {
> /** @vm.xe: xarray to store VMs */
> struct xarray xa;
> /**
> - * @vm.lock: Protects VM lookup + reference and removal a from
> + * @vm.lock: Protects VM lookup + reference and removal from
> * file xarray. Not an intended to be an outer lock which does
> * thing while being held.
> */
> @@ -610,8 +610,8 @@ struct xe_file {
> struct xarray xa;
> /**
> * @exec_queue.lock: Protects exec queue lookup + reference and
> - * removal a frommfile xarray. Not an intended to be an outer
> - * lock which does thing while being held.
> + * removal from file xarray. Not intended to be an outer lock
> + * which does things while being held.
> */
> struct mutex lock;
> } exec_queue;
[-- Attachment #2: Type: text/html, Size: 2214 bytes --]
next prev parent reply other threads:[~2024-10-30 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 21:43 [PATCH v2 0/4] drm/xe: Fix races on fdinfo Lucas De Marchi
2024-10-29 21:43 ` [PATCH v2 1/4] drm/xe: Add trace to lrc timestamp update Lucas De Marchi
2024-10-30 9:24 ` Nirmoy Das
2024-10-29 21:43 ` [PATCH v2 2/4] drm/xe: Stop accumulating LRC timestamp on job_free Lucas De Marchi
2024-10-29 21:43 ` [PATCH v2 3/4] drm/xe: Reword exec_queue.lock doc Lucas De Marchi
2024-10-29 21:50 ` Cavitt, Jonathan
2024-10-30 9:28 ` Nirmoy Das [this message]
2024-10-29 21:43 ` [PATCH v2 4/4] drm/xe: Wait on killed exec queues Lucas De Marchi
2024-10-29 22:05 ` Cavitt, Jonathan
2024-10-30 14:01 ` Lucas De Marchi
2024-10-30 10:56 ` Matthew Auld
2024-10-30 13:30 ` Lucas De Marchi
2024-10-29 22:30 ` ✓ CI.Patch_applied: success for drm/xe: Fix races on fdinfo (rev3) Patchwork
2024-10-29 22:30 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 22:31 ` ✓ CI.KUnit: success " Patchwork
2024-10-29 22:43 ` ✓ CI.Build: " Patchwork
2024-10-29 22:47 ` ✓ CI.Hooks: " Patchwork
2024-10-29 22:49 ` ✓ CI.checksparse: " Patchwork
2024-10-29 23:11 ` ✓ CI.BAT: " Patchwork
2024-10-29 23:48 ` [PATCH v2 0/4] drm/xe: Fix races on fdinfo Umesh Nerlige Ramappa
2024-10-30 3:24 ` ✗ CI.FULL: failure for drm/xe: Fix races on fdinfo (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4a5fe8-fb47-4429-94e3-815da323c5b2@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox