Re: [PATCH v4 06/13] drm/xe/xe_ras: Add basic structures and commands for uncorrectable errors

Raag Jadav
2026-04-20T07:49:09Z

On Mon, Apr 20, 2026 at 11:04:40AM +0530, Tauro, Riana wrote:
> On 4/18/2026 3:02 AM, Matt Roper wrote:
> > On Fri, Apr 17, 2026 at 02:25:28PM -0700, Jadav, Raag wrote:
> > > > -----Original Message-----
> > > > From: Roper, Matthew D <matthew.d.roper@intel.com>
> > > > On Fri, Apr 17, 2026 at 02:28:18PM +0530, Riana Tauro wrote:
> > > > > Add the commands and common structures for the get_soc_error
> > > > > sysctrl command.
> > > ...
> > >
> > > > > +/* Severity classification of detected errors */
> > > > > +enum xe_ras_severity {
> > > > > + XE_RAS_SEVERITY_NOT_SUPPORTED = 0,
> > > > > + XE_RAS_SEVERITY_CORRECTABLE,
> > > > > + XE_RAS_SEVERITY_UNCORRECTABLE,
> > > > > + XE_RAS_SEVERITY_INFORMATIONAL,
> > > > > + XE_RAS_SEVERITY_MAX
> > > > > +};
> > > > Drive-by comment: I notice that there's a fair amount of common changes
> > > > between this uncorrectable series and Raag's correctable series, e.g.,
> > > > https://lore.kernel.org/all/20260410102744.427150-4-raag.jadav@intel.com/
> > > > However it seems that there have been some minor style differences
> > > > between the two that would be good to reconcile (e.g., this series
> > > > writes out the full XE_RAS_SEVERITY_*, XE_RAS_COMPONENT_*, etc.
> > > > whereas
> > > > Raag's series uses slightly shorter XE_RAS_SEV_*, XE_RAS_COMP_*, etc.
> > > > names). Similar differences exist on some of the functions like
> > > > severity_to_string (taking both the device and the severity) here vs
> > > > sev_to_string (taking only the serverity) in the other series.
> > > >
> > > > We should probably figure out which form we actually want to go with so
> > > > that we don't have last-minute conflicts as we start applying these
> > > > series.
> > > The one's in my series are consistent with uapi, but I'm okay with
> > > either one. My only concern is that we don't invent overly long names
> > > that warrant ugly wrapping while using them in the code.
> > Yeah, I don't have any strong feelings one way or the other. But if I
> > want to apply both your series and Riana's series to the same branch for
> > tracking or testing, I'm left uncertain which series I should favor on
> > the conflict resolutions. It would be good if we could come to a
> > decision early just so the two series don't drift apart.
> >
> Yeah using the full word here wasn't creating longer names so i preferred it
> over abbrevations.
> I will make the patch in-line with Raag's patch in the next rev.
>
> His series has got all RB's so might land before this series.

I don't believe we should land it without your review ;)

Raag