From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45F18C87FC9 for ; Wed, 30 Jul 2025 07:33:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0622310E414; Wed, 30 Jul 2025 07:33:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="asRm62rZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62C1410E414; Wed, 30 Jul 2025 07:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753860809; x=1785396809; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=J/DF82vY9AQfyMEnKc2GeKsCmMDYYLcYh0binxJAzfw=; b=asRm62rZdaOWpFiPMcmOJxozOpeN+E7H5m/4d73Akn1r+qtuKLC4bwdR sjqJL4DxaD2BrP4KuBwjgh0EXSTrAsuegpPju7a9VKJWRMcDHNxqsHvTe 6XHJW2fDYnrzEFKsB5ZhJoR1lF48f7sCC5XkcHAhOMU8BnVY8pDZsWj3F JgJjhloy4pJ6XQ4Q2ZQFnoRyuYn2PNJ7yCH/TR2WPrcXd4fe4FYQgmjNs EMaLK5zER4x1CjorE0/u7x911R+CLitLVUQon9Qaxc0kfwGmc1v7PaWXT Kbg6qdxtq+uCTiyRs+aj3K6h7jMJQlRey4m9D9LNdY8Bf0sAm0ZhSxD3U g==; X-CSE-ConnectionGUID: IROtbO0DSm637Ge/2vDswA== X-CSE-MsgGUID: d9E9lHW0SCmgYnN/clDOKw== X-IronPort-AV: E=McAfee;i="6800,10657,11506"; a="56240650" X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208";a="56240650" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 00:33:27 -0700 X-CSE-ConnectionGUID: pG2H9bwOTIm7LhHs6VP/eQ== X-CSE-MsgGUID: YrNcR0FfTlqbQb28V9VyBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208";a="162636373" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.74]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 00:33:24 -0700 From: Jani Nikula To: Nemesa Garg , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Nemesa Garg , Ankit Nautiyal Subject: Re: [PATCH 02/10] drm/i915/display: Introduce HAS_CASF for sharpness support In-Reply-To: <2c93ca60e6125a9bd1792fb0b00dd01dd6705781@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250724134544.284371-1-nemesa.garg@intel.com> <20250724134544.284371-3-nemesa.garg@intel.com> <2c93ca60e6125a9bd1792fb0b00dd01dd6705781@intel.com> Date: Wed, 30 Jul 2025 10:33:21 +0300 Message-ID: <559c287032ae48697188eefa78b769da322b8063@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 30 Jul 2025, Jani Nikula wrote: > On Thu, 24 Jul 2025, Nemesa Garg wrote: >> Add HAS_CASF macro to check whether platform supports >> the content adaptive sharpness capability or not. >> >> v2: Update commit message[Ankit] >> >> Signed-off-by: Nemesa Garg >> Reviewed-by: Ankit Nautiyal >> --- >> drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 7 +++++++ >> drivers/gpu/drm/i915/display/intel_display_device.h | 1 + >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c >> index 0c7f91046996..33ec30123214 100644 >> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c >> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c >> @@ -373,6 +373,13 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, >> >> intel_vdsc_state_dump(&p, 0, pipe_config); >> >> + if (HAS_CASF(display)) { >> + drm_printf(&p, "sharpness strength: %d, sharpness tap size :%d\n sharpness enable :%d\n", > > No \n in the middle please. Moreover, place the space after ":" not before. > >> + pipe_config->hw.casf_params.strength, >> + pipe_config->hw.casf_params.win_size, >> + pipe_config->hw.casf_params.casf_enable); >> + } >> + >> dump_planes: >> if (!state) >> return; >> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h >> index 4308822f0415..7f76215195d8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_device.h >> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h >> @@ -145,6 +145,7 @@ struct intel_display_platforms { >> #define HAS_ASYNC_FLIPS(__display) (DISPLAY_VER(__display) >= 5) >> #define HAS_AS_SDP(__display) (DISPLAY_VER(__display) >= 13) >> #define HAS_BIGJOINER(__display) (DISPLAY_VER(__display) >= 11 && HAS_DSC(__display)) >> +#define HAS_CASF(__display) (DISPLAY_VER(__display) >= 20) >> #define HAS_CDCLK_CRAWL(__display) (DISPLAY_INFO(__display)->has_cdclk_crawl) >> #define HAS_CDCLK_SQUASH(__display) (DISPLAY_INFO(__display)->has_cdclk_squash) >> #define HAS_CMRR(__display) (DISPLAY_VER(__display) >= 20) -- Jani Nikula, Intel