Re: [PATCH 3/3] drm/xe/query: Tidy up error EFAULT returns

["Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com>]

On 10-10-2024 09:18, Lucas De Marchi wrote:
> Move the error handling together in a single branch since all of them
> are doing similar thing and return the same error.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

The logic remains the same, LGTM,

Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_query.c | 14 ++++----------
>   1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index d86959076b078..cd2799c0ba510 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -163,16 +163,10 @@ query_engine_cycles(struct xe_device *xe,
>   		resp.width = 36;
>   
>   	/* Only write to the output fields of user query */
> -	if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp))
> -		return -EFAULT;
> -
> -	if (put_user(resp.cpu_delta, &query_ptr->cpu_delta))
> -		return -EFAULT;
> -
> -	if (put_user(resp.engine_cycles, &query_ptr->engine_cycles))
> -		return -EFAULT;
> -
> -	if (put_user(resp.width, &query_ptr->width))
> +	if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp) ||
> +	    put_user(resp.cpu_delta, &query_ptr->cpu_delta) ||
> +	    put_user(resp.engine_cycles, &query_ptr->engine_cycles) ||
> +	    put_user(resp.width, &query_ptr->width))
>   		return -EFAULT;
>   
>   	return 0;