Re: [PATCH] drm/xe/pf: Fix the address range assert in ggtt_get_pte helper

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 1/30/2026 10:56 PM, Michał Winiarski wrote:
> The ggtt_get_pte helper used for saving VF GGTT incorrectly assumes that
> ggtt_size == ggtt_end.
> Fix it to avoid triggering spurious asserts if VF GGTT object lands in
> high GGTT range.

and now it matches assert in xe_ggtt_set_pte

> 
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> --->  drivers/gpu/drm/xe/xe_ggtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 60665ad1415be..10bbf7a86b487 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -193,7 +193,7 @@ static void xe_ggtt_set_pte_and_flush(struct xe_ggtt *ggtt, u64 addr, u64 pte)
>  static u64 xe_ggtt_get_pte(struct xe_ggtt *ggtt, u64 addr)
>  {
>  	xe_tile_assert(ggtt->tile, !(addr & XE_PTE_MASK));
> -	xe_tile_assert(ggtt->tile, addr < ggtt->size);
> +	xe_tile_assert(ggtt->tile, addr < ggtt->start + ggtt->size);
>  
>  	return readq(&ggtt->gsm[addr >> XE_PTE_SHIFT]);
>  }