Re: [PATCH v8 1/1] drm/xe: Add helper macro to loop each dss

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Wed, 2024-01-31 at 16:14 -0800, Zhanjun Dong wrote:
> 
alan:snip


> @@ -167,3 +164,28 @@ bool xe_gt_topology_has_dss_in_quadrant(struct
> xe_gt *gt, int quad)
>  
>         return quad_first < (quad + 1) * dss_per_quad;
>  }
> +
> +/**
> + * xe_gt_topology_get_next_dss - returns the next DSS id from a
> start position
> 
> + * @gt: GT structure
> + * @from: An index to start search form
> + *
> + * Search from topology dss masks, returns the dss ID indicate the
> next bit was set.
> + * Depends on platform construction, dss could be on geometry or on
> compute mask.
> + * The combined bit mask supports it all.
alan: nit.. i could over editting this so feel free to ignore or clip,
but I believe this documentation might read better as:

Search from this GT's DSS-fuses-topology and return the DSS-ID of the
next valid DSS instance after DSS-ID 'from'. Depending on the platform
construction, DSS instances could be for geometry (RENDER engine) or
compute (COMPUTE engine). However, all current platforms that have
both engines have the same instances thus we can combine both masks
internally before performing this operation.
> + *
> + * Return -1 if not found since given "from" position.
> + */
alan:snip

alan: Going thru v6's review comments from Matt, it looks like you've
addressed them all. Since above is a nit, here is my RB:

Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>