Re: [PATCH v7 1/7] drm/xe/guc: Update GuC ADS size for error capture

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Wed, 2024-03-27 at 13:40 -0700, Zhanjun Dong wrote:
alan:snip

> +
> +/**
> + * struct xe_guc_state_capture
> + *
> + * Internal context of the xe_guc_capture module.
> + */
> +struct xe_guc_state_capture {
alan:snip..

> +#define PREALLOC_NODES_MAX_COUNT (3 * GUC_MAX_ENGINE_CLASSES * GUC_MAX_INSTANCES_PER_CLASS)
> +#define PREALLOC_NODES_DEFAULT_NUMREGS 64
> +
> +       /**
> +        * @max_mmio_per_node: Max MMIO per node.
> +        */
> +       int max_mmio_per_node;
> +
> +       /**
> +        * @outlist: Pool of pre-allocated nodes for error capture output
> +        *
> +        * A linked list of parsed GuC error-capture output data before
> +        * reporting with formatting via i915_gpu_coredump. Each node in this linked list shall
alan: i think u meant to replace "i915" with the newer xe-dev-coredump variation in above comment
alan:snip