Re: [PATCH 2/3] drm/xe/pxp: Remove incorrect handling of impossible state during suspend

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 2/23/2026 2:42 PM, Julia Filipchuk wrote:
> On 2/18/2026 4:26 PM, Daniele Ceraolo Spurio wrote:
>> The default case of the PXP suspend switch is incorrectly exiting
>> without releasing the lock. However, this case is impossible to hit
>> because we're switching on an enum and all the valid enum values have
>> their own cases. Therefore, we can just get rid of the default case
>> and rely on the compiler to warn us if a new enum value is added and
>> we forget to add it to the switch.
> I understand the reasoning but prefer just adding a 'mutex_unlock(&pxp->mutex);'
> to keep the check. The case for XE_PXP_START_IN_PROGRESS does this before goto.

Which check are you referring to? it's impossible for that code to ever 
be executed, so keeping it doesn't actually change anything at runtime.

>
> There is a similar pattern in pxp_start that correctly releases the mutex on
> cleanup. Any reason to remove it too?

Yeah we can remove that one as well, but it should be done separately 
since it's not a fix.

>
>