Re: [PATCH v2 2/3] drm/xe: Pre-allocate system memory for pinned external bos in the pm notfier

[Matthew Auld <matthew.auld@intel.com>]

On 18/09/2025 10:22, Thomas Hellström wrote:
> Similarly to what we do for other pinned bos, pre-allocate
> system memory for pinned external bos in the pm notifier,
> where swapping is still possible.
> 
> This hasn't been needed until now when we're about to allow
> pinning of exernal VRAM bos.
> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_bo_evict.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo_evict.c b/drivers/gpu/drm/xe/xe_bo_evict.c
> index d5dbc51e8612..1a12675b2ea9 100644
> --- a/drivers/gpu/drm/xe/xe_bo_evict.c
> +++ b/drivers/gpu/drm/xe/xe_bo_evict.c
> @@ -73,6 +73,11 @@ int xe_bo_notifier_prepare_all_pinned(struct xe_device *xe)
>   					    &xe->pinned.late.kernel_bo_present,
>   					    xe_bo_notifier_prepare_pinned);
>   
> +	if (!ret)
> +		ret = xe_bo_apply_to_pinned(xe, &xe->pinned.late.external,
> +					    &xe->pinned.late.external,
> +					    xe_bo_notifier_prepare_pinned);
> +
>   	return ret;
>   }
>   
> @@ -93,6 +98,10 @@ void xe_bo_notifier_unprepare_all_pinned(struct xe_device *xe)
>   	(void)xe_bo_apply_to_pinned(xe, &xe->pinned.late.kernel_bo_present,
>   				    &xe->pinned.late.kernel_bo_present,
>   				    xe_bo_notifier_unprepare_pinned);
> +
> +	(void)xe_bo_apply_to_pinned(xe, &xe->pinned.late.external,
> +				    &xe->pinned.late.external,
> +				    xe_bo_notifier_unprepare_pinned);
>   }
>   
>   /**