Re: [PATCH] drm/i915/dp: Simplify intel_dp_needs_8b10b_fec()

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Mon, 2025-10-20 at 18:44 +0300, Imre Deak wrote:
> The intel_crtc_state::fec_enable check in intel_dp_needs_8b10b_fec()
> is
> redundant drop it: originally it ensured that the FEC enabled state
> for
> a CRTC other than the CRTC intel_dp_needs_8b10b_fec() called for is
> preserved, even if DSC is not enabled for the latter CRTC. The way
> FEC
> gets enabled for all the CRTCs on an 8b10b MST link is changed by
> 
> commit 7c027070e98d ("drm/i915/dp_mst: Track DSC enabled status on
> the
> MST link") and
> commit 470b84af457e ("drm/i915/dp_mst: Recompute all MST link CRTCs
> if
> DSC gets enabled on the link")
> 
> depending on intel_dsc_enabled_on_link() in
> intel_dp_needs_8b10b_fec()
> instead of the above fec_enable check. Drop the check.
> 
> Suggested-by: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index b0aeb6c2de86c..475518b4048b7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2377,9 +2377,6 @@ bool intel_dp_needs_8b10b_fec(const struct
> intel_crtc_state *crtc_state,
>  	if (intel_dp_is_uhbr(crtc_state))
>  		return false;
>  
> -	if (crtc_state->fec_enable)
> -		return true;
> -
>  	/*
>  	 * Though eDP v1.5 supports FEC with DSC, unlike DP, it is
> optional.
>  	 * Since, FEC is a bandwidth overhead, continue to not
> enable it for