Re: [PATCH] drm/xe: Use __counted_by for flexible arrays

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 18-10-2024 08:30, Matthew Brost wrote:
> Good practice to use __counted_by in kernel coding for flexible arrays.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 +-
>   drivers/gpu/drm/xe/xe_sched_job_types.h  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index 7deb480e26af..1158b6062a6c 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -143,7 +143,7 @@ struct xe_exec_queue {
>   	/** @hw_engine_group_link: link into exec queues in the same hw engine group */
>   	struct list_head hw_engine_group_link;
>   	/** @lrc: logical ring context for this exec queue */
> -	struct xe_lrc *lrc[];
> +	struct xe_lrc *lrc[] __counted_by(width);
>   };
>   
>   /**
> diff --git a/drivers/gpu/drm/xe/xe_sched_job_types.h b/drivers/gpu/drm/xe/xe_sched_job_types.h
> index 0d3f76fb05ce..426d261d7359 100644
> --- a/drivers/gpu/drm/xe/xe_sched_job_types.h
> +++ b/drivers/gpu/drm/xe/xe_sched_job_types.h
> @@ -63,7 +63,7 @@ struct xe_sched_job {
>   
>   struct xe_sched_job_snapshot {
>   	u16 batch_addr_len;
> -	u64 batch_addr[];
> +	u64 batch_addr[] __counted_by(batch_addr_len);
>   };

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   #endif