From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D39AE77184 for ; Tue, 17 Dec 2024 20:39:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA95810EA67; Tue, 17 Dec 2024 20:39:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.b="PG/yu+KT"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="3S/Q4XAN"; dkim-atps=neutral Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by gabe.freedesktop.org (Postfix) with ESMTPS id D777B10E7F2; Tue, 17 Dec 2024 20:39:36 +0000 (UTC) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id A19D21140119; Tue, 17 Dec 2024 15:39:35 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Tue, 17 Dec 2024 15:39:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1734467975; x=1734554375; bh=aNNu1aV97H2ywQy9HYkfKUll79gVGt2TM223JqGvvs0=; b= PG/yu+KTPMi3QOwd5YeCYAtnAO6GxkyhDpWZ2jHJ9e01an0XFJbkp6HpHakcJYwH tRvpllFJCZJEtzW+eDTT4tuEmQZhrLjq/qux+HIuPGTVUwWQBXbSxA6iBLTO7Hkf MpLc7cqCb7wx5yNEc4nw7drIyKRc/cgwY79sWTGjR1Xxs858JDD15mRe5sSccrrX EMbyRqQ7sef7mhuGx0x0M2zvTrmM8TEgeHpHLXv3Ewy3AR5AWkpjiRdpITbAgUOO q/fsqvtmv+oVx6r1QotMq+8TFGjNjmpm4qI2TORKNxt7h6xbuNNnfLoHSdcav+qt dmVfNU8x3ojd3tvGHdeieA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1734467975; x= 1734554375; bh=aNNu1aV97H2ywQy9HYkfKUll79gVGt2TM223JqGvvs0=; b=3 S/Q4XANwWKlgrl/i7TYzGY72PYpt+m85aWZjas1aIUZApsDV7Ny1s9IqKQrf/i+k hS8by/eS8C15wL6wU4envoksEiT7CtDWeSQfSZr6p9BP96ZP1m8JIwyqBP9nwwm5 kjAZnbVGhXnHc1Ew4wEoZ94uiZlLga0PIOYPnViDQU/6RdnD9He2ZFwU2hiPblzG DZ+BMPtSxQC4h5jhaokMx6YeGI9fmZYbe/tbofqeMdvqr107T3Da4JZmTaYywoRw I50EJeO6H2gDnvsspkEY7IkgOZm5jWxbRzYWOl8jNocebskev8K9PDCoaKEqoztX 8Jn04avWDmRKyM47ktPkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrleehgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsihhmohhnrgesfhhffihllhdrtg hhpdhrtghpthhtohepghgvvghrthdorhgvnhgvshgrshesghhlihguvghrrdgsvgdprhgt phhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhgrnhhird hnihhkuhhlrgesihhnthgvlhdrtghomhdprhgtphhtthhopehluhgtrghsrdguvghmrghr tghhihesihhnthgvlhdrtghomhdprhgtphhtthhopehmihgthhgrvghlrdhjrdhruhhhlh esihhnthgvlhdrtghomhdprhgtphhtthhopehrohgurhhighhordhvihhvihesihhnthgv lhdrtghomhdprhgtphhtthhopehtvghjrghsrdhuphgrughhhigrhiesihhnthgvlhdrtg homhdprhgtphhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 88DA52220072; Tue, 17 Dec 2024 15:39:34 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Tue, 17 Dec 2024 21:39:13 +0100 From: "Arnd Bergmann" To: "Lucas De Marchi" Cc: "Rodrigo Vivi" , "Arnd Bergmann" , michael.j.ruhl@intel.com, =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Simona Vetter" , "David E. Box" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "Andy Shevchenko" , "Jani Nikula" , "Geert Uytterhoeven" , "Tejas Upadhyay" , "Hans de Goede" , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-Id: <640211a8-9516-4574-99a6-e61354d613ff@app.fastmail.com> In-Reply-To: References: <20241217071852.2261858-1-arnd@kernel.org> <36bae0e6-9153-4cb4-9c85-8a582a47044b@app.fastmail.com> Subject: Re: [PATCH] drm/xe/vsec: enforce CONFIG_INTEL_VSEC dependency Content-Type: text/plain Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, Dec 17, 2024, at 21:14, Lucas De Marchi wrote: > On Tue, Dec 17, 2024 at 08:28:59PM +0100, Arnd Bergmann wrote: >>On Tue, Dec 17, 2024, at 19:52, Rodrigo Vivi wrote: >>> On Tue, Dec 17, 2024 at 08:18:44AM +0100, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>>> >>>> When INTEL_VSEC is in a loadable module, XE cannot be built-in any more: >>>> >>>> x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init': >>>> (.text+0x19861bf): undefined reference to `intel_vsec_register' >>>> >>>> This could be enforced using a 'depends on INTEL_VSEC || !INTEL_VSEC' >>>> style dependency to allow building with VSEC completely disabled. >>>> My impression here is that this was not actually intended, and that >>>> continuing to support that combination would lead to more build bugs. > > why? if xe is built-in, vsec needs to be built-in as well. If xe is a > module, vsec can be either built-in or a module. "depends on INTEL_VSEC" enforces that hard dependency. The difference with "depends on INTEL_VSEC || !INTEL_VSEC" is that it also allows XE to be either built-in or a module if INTEL_VSEC is turned off, as it would be the case on non-x86. Arnd