From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, lucas.demarchi@intel.com,
ville.syrjala@linux.intel.com, maarten.lankhorst@linux.intel.com,
jani.nikula@intel.com
Subject: [PATCH 07/22] drm/i915/fb: convert intel_fb_bo_lookup_valid_bo() to struct drm_gem_object
Date: Tue, 17 Sep 2024 19:13:46 +0300 [thread overview]
Message-ID: <645307ea7bf858d131ecdeff6ee9c9b99ae00526.1726589119.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1726589119.git.jani.nikula@intel.com>
Prefer the driver agnostic struct drm_gem_object over i915 specific
struct drm_i915_gem_object.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 6 +++---
drivers/gpu/drm/i915/display/intel_fb_bo.c | 4 ++--
drivers/gpu/drm/i915/display/intel_fb_bo.h | 5 +++--
drivers/gpu/drm/xe/display/intel_fb_bo.c | 12 ++++++------
drivers/gpu/drm/xe/display/intel_fb_bo.h | 9 +++++----
5 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index d863550021a0..b705ae05c73e 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -2086,7 +2086,7 @@ intel_user_framebuffer_create(struct drm_device *dev,
const struct drm_mode_fb_cmd2 *user_mode_cmd)
{
struct drm_framebuffer *fb;
- struct drm_i915_gem_object *obj;
+ struct drm_gem_object *obj;
struct drm_mode_fb_cmd2 mode_cmd = *user_mode_cmd;
struct drm_i915_private *i915 = to_i915(dev);
@@ -2094,8 +2094,8 @@ intel_user_framebuffer_create(struct drm_device *dev,
if (IS_ERR(obj))
return ERR_CAST(obj);
- fb = intel_framebuffer_create(obj, &mode_cmd);
- drm_gem_object_put(intel_bo_to_drm_bo(obj));
+ fb = intel_framebuffer_create(to_intel_bo(obj), &mode_cmd);
+ drm_gem_object_put(obj);
return fb;
}
diff --git a/drivers/gpu/drm/i915/display/intel_fb_bo.c b/drivers/gpu/drm/i915/display/intel_fb_bo.c
index 4be09541e509..c9a332afa601 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_bo.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_bo.c
@@ -74,7 +74,7 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
return 0;
}
-struct drm_i915_gem_object *
+struct drm_gem_object *
intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
struct drm_file *filp,
const struct drm_mode_fb_cmd2 *mode_cmd)
@@ -93,5 +93,5 @@ intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
return ERR_PTR(-EREMOTE);
}
- return obj;
+ return intel_bo_to_drm_bo(obj);
}
diff --git a/drivers/gpu/drm/i915/display/intel_fb_bo.h b/drivers/gpu/drm/i915/display/intel_fb_bo.h
index 232bf898b013..e7f4e57e8964 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_bo.h
+++ b/drivers/gpu/drm/i915/display/intel_fb_bo.h
@@ -7,9 +7,10 @@
#define __INTEL_FB_BO_H__
struct drm_file;
-struct drm_mode_fb_cmd2;
+struct drm_gem_object;
struct drm_i915_gem_object;
struct drm_i915_private;
+struct drm_mode_fb_cmd2;
struct intel_framebuffer;
void intel_fb_bo_framebuffer_fini(struct drm_i915_gem_object *obj);
@@ -18,7 +19,7 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
struct drm_i915_gem_object *obj,
struct drm_mode_fb_cmd2 *mode_cmd);
-struct drm_i915_gem_object *
+struct drm_gem_object *
intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
struct drm_file *filp,
const struct drm_mode_fb_cmd2 *user_mode_cmd);
diff --git a/drivers/gpu/drm/xe/display/intel_fb_bo.c b/drivers/gpu/drm/xe/display/intel_fb_bo.c
index 63ce97cc4cfe..a973106d9e8c 100644
--- a/drivers/gpu/drm/xe/display/intel_fb_bo.c
+++ b/drivers/gpu/drm/xe/display/intel_fb_bo.c
@@ -65,11 +65,11 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
return ret;
}
-struct xe_bo *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
- struct drm_file *filp,
- const struct drm_mode_fb_cmd2 *mode_cmd)
+struct drm_gem_object *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
+ struct drm_file *filp,
+ const struct drm_mode_fb_cmd2 *mode_cmd)
{
- struct drm_i915_gem_object *bo;
+ struct xe_bo *bo;
struct drm_gem_object *gem = drm_gem_object_lookup(filp, mode_cmd->handles[0]);
if (!gem)
@@ -78,11 +78,11 @@ struct xe_bo *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
bo = gem_to_xe_bo(gem);
/* Require vram placement or dma-buf import */
if (IS_DGFX(i915) &&
- !xe_bo_can_migrate(gem_to_xe_bo(gem), XE_PL_VRAM0) &&
+ !xe_bo_can_migrate(bo, XE_PL_VRAM0) &&
bo->ttm.type != ttm_bo_type_sg) {
drm_gem_object_put(gem);
return ERR_PTR(-EREMOTE);
}
- return bo;
+ return gem;
}
diff --git a/drivers/gpu/drm/xe/display/intel_fb_bo.h b/drivers/gpu/drm/xe/display/intel_fb_bo.h
index 5d365b925b7a..430acca554fb 100644
--- a/drivers/gpu/drm/xe/display/intel_fb_bo.h
+++ b/drivers/gpu/drm/xe/display/intel_fb_bo.h
@@ -7,8 +7,9 @@
#define __INTEL_FB_BO_H__
struct drm_file;
-struct drm_mode_fb_cmd2;
+struct drm_gem_object;
struct drm_i915_private;
+struct drm_mode_fb_cmd2;
struct intel_framebuffer;
struct xe_bo;
@@ -17,8 +18,8 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
struct xe_bo *bo,
struct drm_mode_fb_cmd2 *mode_cmd);
-struct xe_bo *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
- struct drm_file *filp,
- const struct drm_mode_fb_cmd2 *mode_cmd);
+struct drm_gem_object *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
+ struct drm_file *filp,
+ const struct drm_mode_fb_cmd2 *mode_cmd);
#endif
--
2.39.2
next prev parent reply other threads:[~2024-09-17 16:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 16:13 [PATCH 00/22] drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo Jani Nikula
2024-09-17 16:13 ` [PATCH 01/22] drm/i915/display: start a buffer object abstraction layer Jani Nikula
2024-09-17 16:13 ` [PATCH 02/22] drm/i915/display: convert intel_atomic_plane.c to struct drm_gem_object Jani Nikula
2024-09-17 16:13 ` [PATCH 03/22] drm/i915/fb: convert parts of intel_fb.c " Jani Nikula
2024-09-17 18:22 ` Maarten Lankhorst
2024-09-18 6:26 ` Jani Nikula
2024-09-18 6:25 ` [PATCH v2] " Jani Nikula
2024-09-18 9:24 ` Maarten Lankhorst
2024-09-17 16:13 ` [PATCH 04/22] drm/i915/fbdev: convert intel_fbdev.c " Jani Nikula
2024-09-17 16:13 ` [PATCH 05/22] drm/i915/display: convert skl_universal_plane.c " Jani Nikula
2024-09-17 16:13 ` [PATCH 06/22] drm/i915/fb: convert intel_framebuffer_init() " Jani Nikula
2024-09-17 16:13 ` Jani Nikula [this message]
2024-09-17 16:13 ` [PATCH 08/22] drm/i915/fb: convert intel_fb_bo_framebuffer_init() to struct drm_i915_gem_object Jani Nikula
2024-09-17 16:13 ` [PATCH 09/22] drm/i915/fb: convert intel_fb_bo_framebuffer_fini() " Jani Nikula
2024-09-17 16:13 ` [PATCH 10/22] drm/xe/display: use correct bo type in intel_fbdev_fb_alloc() Jani Nikula
2024-09-19 13:21 ` Lucas De Marchi
2024-09-17 16:13 ` [PATCH 11/22] drm/i915/fb: convert intel_framebuffer_create() to struct drm_gem_object Jani Nikula
2024-09-17 16:13 ` [PATCH 12/22] drm/xe/display: stop using intel_fb_obj() in xe_fb_pin.c Jani Nikula
2024-09-19 13:20 ` Lucas De Marchi
2024-09-17 16:13 ` [PATCH 13/22] drm/i915/display: add intel_bo_read_from_page() and use it Jani Nikula
2024-09-17 16:13 ` [PATCH 14/22] drm/i915/display: add intel_bo_get/set_frontbuffer() and use them Jani Nikula
2024-09-17 16:13 ` [PATCH 15/22] drm/i915/frontbuffer: convert intel_frontbuffer_get() to struct drm_gem_object Jani Nikula
2024-09-17 16:13 ` [PATCH 16/22] drm/i915/frontbuffer: convert frontbuffer->obj " Jani Nikula
2024-09-17 16:13 ` [PATCH 17/22] drm/i915/display: add intel_bo_describe() and use it Jani Nikula
2024-09-17 16:13 ` [PATCH 18/22] drm/i915/fb: remove intel_fb_obj() Jani Nikula
2024-09-17 16:13 ` [PATCH 19/22] drm/i915/display: clean up some gem/ includes Jani Nikula
2024-09-17 16:13 ` [PATCH 20/22] drm/xe/compat: remove a bunch of compat gem headers Jani Nikula
2024-09-19 13:16 ` Lucas De Marchi
2024-09-17 16:14 ` [PATCH 21/22] drm/xe: remove a number of superfluous compat macros Jani Nikula
2024-09-19 13:20 ` Lucas De Marchi
2024-09-17 16:14 ` [PATCH 22/22] drm/xe: eradicate -Ddrm_i915_gem_object=xe_bo Jani Nikula
2024-09-17 21:53 ` Maarten Lankhorst
2024-09-19 13:19 ` Lucas De Marchi
2024-09-17 16:22 ` ✓ CI.Patch_applied: success for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo Patchwork
2024-09-17 16:22 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-17 16:24 ` ✓ CI.KUnit: success " Patchwork
2024-09-17 16:35 ` ✓ CI.Build: " Patchwork
2024-09-17 16:38 ` ✓ CI.Hooks: " Patchwork
2024-09-17 16:39 ` ✗ CI.checksparse: warning " Patchwork
2024-09-17 16:57 ` ✓ CI.BAT: success " Patchwork
2024-09-17 18:06 ` ✗ CI.FULL: failure " Patchwork
2024-09-18 8:58 ` ✓ CI.Patch_applied: success for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2) Patchwork
2024-09-18 8:59 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-18 9:04 ` ✓ CI.KUnit: success " Patchwork
2024-09-18 9:21 ` ✓ CI.Build: " Patchwork
2024-09-18 9:23 ` ✓ CI.Hooks: " Patchwork
2024-09-18 9:25 ` ✗ CI.checksparse: warning " Patchwork
2024-09-18 12:34 ` [PATCH 00/22] drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo Jani Nikula
2024-09-18 12:46 ` ✗ CI.FULL: failure for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2) Patchwork
2024-09-19 13:42 ` [PATCH 00/22] drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645307ea7bf858d131ecdeff6ee9c9b99ae00526.1726589119.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox