From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: "Arnd Bergmann" <arnd@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Michał Winiarski" <michal.winiarski@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Matthew Brost <matthew.brost@intel.com>,
Lucas De Marchi <demarchi@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Riana Tauro <riana.tauro@intel.com>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe/pf: fix VFIO link error
Date: Thu, 4 Dec 2025 13:10:58 +0100 [thread overview]
Message-ID: <64aa446c-eaea-40c6-982a-6308ab0b87dc@intel.com> (raw)
In-Reply-To: <20251204094154.1029357-1-arnd@kernel.org>
On 12/4/2025 10:41 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Makefile logic for building xe_sriov_vfio.o was added incorrectly,
> as setting CONFIG_XE_VFIO_PCI=m means it doesn't get included into a
> built-in xe driver:
>
> ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_suspend_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_wait_flr_done" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_migration_supported" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
>
> Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide whether to
> include the the object instead.
>
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index dfc2ded01455..e5f3c2ec9e9a 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) += \
> xe_sriov_pf_sysfs.o \
> xe_tile_sriov_pf_debugfs.o
>
> -ifeq ($(CONFIG_PCI_IOV),y)
> - xe-$(CONFIG_XE_VFIO_PCI) += xe_sriov_vfio.o
> +ifdef CONFIG_XE_VFIO_PCI
> + xe-$(CONFIG_PCI_IOV) += xe_sriov_vfio.o
> endif
>
> # include helpers for tests even when XE is built-in
next prev parent reply other threads:[~2025-12-04 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:41 [PATCH] drm/xe/pf: fix VFIO link error Arnd Bergmann
2025-12-04 9:46 ` ✗ CI.checkpatch: warning for " Patchwork
2025-12-04 9:48 ` ✓ CI.KUnit: success " Patchwork
2025-12-04 11:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-04 12:10 ` Michal Wajdeczko [this message]
2025-12-04 12:19 ` [PATCH] " Thomas Hellström
2025-12-04 13:43 ` Arnd Bergmann
2025-12-04 13:44 ` Thomas Hellström
2025-12-04 12:22 ` ✓ Xe.CI.Full: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64aa446c-eaea-40c6-982a-6308ab0b87dc@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=demarchi@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=michal.winiarski@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox