From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52027CCF9E3 for ; Tue, 11 Nov 2025 11:16:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1153110E55E; Tue, 11 Nov 2025 11:16:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NMP5pAxl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD1C010E55D; Tue, 11 Nov 2025 11:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762859811; x=1794395811; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=3Ix57xbL8rxknAaZUUl2yxwx7P4koXb3n/R0HUcP+J8=; b=NMP5pAxldoFfh0ll/Xl3hvkRS6GzNIaVHpSBWhnaMN14a95wVpGVvrkl zdFbRzAnbvP2F5yVoAvhPi9oMLpowdzJUhyTlRY1ticdcyqZ/vTRR82/Y lUjFFtQIGIpnE6V3CTEbQGxjm0u4x/BDVIH71vA6EpkBamyjWZFH9sRgJ sWYmaIyf+X0FtEEzr7wn3eOzqjAbrQAZ+jozWOIUvpxOCVq2KsdYagHUp Er1Kr/0Til9qsEKtqyKyitAgD9Jp6ZcYcg799WxMbGrrSQSzNV9Ck9bBV VFflGw7iHS34HnGnEHimFWdZXgOP8/X8Gh4wz3/LiHACl9aqpbJHtGBtC Q==; X-CSE-ConnectionGUID: bJwiRAkASlaKXL+rhCC9rg== X-CSE-MsgGUID: HlSosxHIRAi0avhvdsBXog== X-IronPort-AV: E=McAfee;i="6800,10657,11609"; a="75536410" X-IronPort-AV: E=Sophos;i="6.19,296,1754982000"; d="scan'208";a="75536410" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2025 03:16:51 -0800 X-CSE-ConnectionGUID: bL61MaS2Qbqf9QlTPTYWMw== X-CSE-MsgGUID: 7LjUKO8/Swqa2casj2HICQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,296,1754982000"; d="scan'208";a="188581695" Received: from mjarzebo-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.239]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2025 03:16:49 -0800 From: Jani Nikula To: Mika Kahola , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Imre Deak , Mika Kahola Subject: Re: [CI 14/32] drm/i915/display: Print additional Cx0 PLL HW state In-Reply-To: <141250547b313dd31f20741af553847f1e2bfa45@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20251031103549.173208-1-mika.kahola@intel.com> <20251031103549.173208-15-mika.kahola@intel.com> <141250547b313dd31f20741af553847f1e2bfa45@intel.com> Date: Tue, 11 Nov 2025 13:16:46 +0200 Message-ID: <64c941480959a8e70cd903d414bd55a3e47a67d7@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 11 Nov 2025, Jani Nikula wrote: > On Fri, 31 Oct 2025, Mika Kahola wrote: >> From: Imre Deak >> >> Print all the Cx0 PLL state in the PLL state dumper. >> >> Signed-off-by: Imre Deak >> Signed-off-by: Mika Kahola >> --- >> drivers/gpu/drm/i915/display/intel_cx0_phy.c | 18 +++++++++++++++--- >> 1 file changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c >> index 3418fc560faf..1e68a73c2ca8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c >> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c >> @@ -2311,8 +2311,8 @@ static void intel_c10pll_dump_hw_state(struct intel_display *display, >> unsigned int multiplier, tx_clk_div; >> >> fracen = hw_state->pll[0] & C10_PLL0_FRACEN; >> - drm_dbg_kms(display->drm, "c10pll_hw_state: fracen: %s, ", >> - str_yes_no(fracen)); >> + drm_dbg_kms(display->drm, "c10pll_hw_state: clock: %d, fracen: %s, ", >> + hw_state->clock, str_yes_no(fracen)); >> >> if (fracen) { >> frac_quot = hw_state->pll[12] << 8 | hw_state->pll[11]; >> @@ -2835,7 +2835,7 @@ static void intel_c20pll_dump_hw_state(struct intel_display *display, >> { >> int i; >> >> - drm_dbg_kms(display->drm, "c20pll_hw_state:\n"); >> + drm_dbg_kms(display->drm, "c20pll_hw_state clock: %d:\n", hw_state->clock); >> drm_dbg_kms(display->drm, >> "tx[0] = 0x%.4x, tx[1] = 0x%.4x, tx[2] = 0x%.4x\n", >> hw_state->tx[0], hw_state->tx[1], hw_state->tx[2]); >> @@ -2851,12 +2851,24 @@ static void intel_c20pll_dump_hw_state(struct intel_display *display, >> for (i = 0; i < ARRAY_SIZE(hw_state->mplla); i++) >> drm_dbg_kms(display->drm, "mplla[%d] = 0x%.4x\n", i, >> hw_state->mplla[i]); >> + >> + /* For full coverage, also print the additional PLL B entry. */ >> + WARN_ON(i + 1 != ARRAY_SIZE(hw_state->mpllb)); > > Why? What if we hit this? At the very least please use > drm_WARN_ON(). What does the comment have to do with the WARN? Besides after the loop i == ARRAY_SIZE(hw_state->mplla), i.e. the whole thing can be BUILD_BUG_ON(ARRAY_SIZE(hw_state->mplla) + 1 != ARRAY_SIZE(hw_state->mpllb)); > >> + drm_dbg_kms(display->drm, "mpllb[%d] = 0x%.4x\n", i, hw_state->mpllb[i]); >> } >> + >> + drm_dbg_kms(display->drm, "vdr: custom width: 0x%02x, serdes rate: 0x%02x, hdmi rate: 0x%02x\n", >> + hw_state->vdr.custom_width, hw_state->vdr.serdes_rate, hw_state->vdr.hdmi_rate); >> } >> >> void intel_cx0pll_dump_hw_state(struct intel_display *display, >> const struct intel_cx0pll_state *hw_state) >> { >> + drm_dbg_kms(display->drm, >> + "cx0pll_hw_state: lane_count: %d, ssc_enabled: %s, use_c10: %s, tbt_mode: %s\n", >> + hw_state->lane_count, str_yes_no(hw_state->ssc_enabled), >> + str_yes_no(hw_state->use_c10), str_yes_no(hw_state->tbt_mode)); >> + >> if (hw_state->use_c10) >> intel_c10pll_dump_hw_state(display, &hw_state->c10); >> else -- Jani Nikula, Intel