Re: [PATCH] drm/xe/hwmon: Remove unwanted write permission for currN_label

[Riana Tauro <riana.tauro@intel.com>]

On 4/19/2024 6:29 PM, Karthik Poosa wrote:
> Change umode of currN_label from 0644 to 0444 as write permission
> not needed for label.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_hwmon.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 453e601ddd5e..dca275117232 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -550,12 +550,17 @@ xe_hwmon_curr_is_visible(const struct xe_hwmon *hwmon, u32 attr, int channel)
>   {
>   	u32 uval;
>   
> +	/* hwmon sysfs attribute of current available only for package */
> +	if (channel != CHANNEL_PKG)
> +		return 0;
> +
>   	switch (attr) {
>   	case hwmon_curr_crit:
> -	case hwmon_curr_label:
> -		if (channel == CHANNEL_PKG)
>   			return (xe_hwmon_pcode_read_i1(hwmon->gt, &uval) ||
>   				(uval & POWER_SETUP_I1_WATTS)) ? 0 : 0644;
> +	case hwmon_curr_label:
> +			return (xe_hwmon_pcode_read_i1(hwmon->gt, &uval) ||
> +				(uval & POWER_SETUP_I1_WATTS)) ? 0 : 0444;
>   		break;
>   	default:
>   		return 0;