From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, <dri-devel@lists.freedesktop.org>
Cc: <intel-xe@lists.freedesktop.org>, Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] drm/gem: fix build for mm_get_unmapped_area() call after backmerge
Date: Mon, 15 Dec 2025 15:20:16 +0530 [thread overview]
Message-ID: <65d38da8-3591-4e80-a19d-0e15aad41710@intel.com> (raw)
In-Reply-To: <20251215092706.3218018-1-jani.nikula@intel.com>
On 15-12-2025 14:57, Jani Nikula wrote:
> Commit 9ac09bb9feac ("mm: consistently use current->mm in
> mm_get_unmapped_area()") upstream dropped a parameter from
> mm_get_unmapped_area() while commit 99bda20d6d4c ("drm/gem: Introduce
> drm_gem_get_unmapped_area() fop") in drm-misc-next added a new user.
>
> Drop the extra parameter from the call.
>
> Fixes: 7f790dd21a93 ("Merge drm/drm-next into drm-misc-next")
> Cc: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_gem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index bcc08a6aebf8..28d6792112be 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -1303,8 +1303,7 @@ unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long uaddr,
>
> obj = drm_gem_object_lookup_at_offset(filp, pgoff, len >> PAGE_SHIFT);
> if (IS_ERR(obj) || !obj->filp || !obj->filp->f_op->get_unmapped_area)
> - return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0,
> - flags);
> + return mm_get_unmapped_area(filp, uaddr, len, 0, flags);
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
>
> ret = obj->filp->f_op->get_unmapped_area(obj->filp, uaddr, len, 0,
> flags);
next prev parent reply other threads:[~2025-12-15 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 9:27 [PATCH] drm/gem: fix build for mm_get_unmapped_area() call after backmerge Jani Nikula
2025-12-15 9:34 ` ✓ CI.KUnit: success for " Patchwork
2025-12-15 9:36 ` [PATCH] " Francois Dugast
2025-12-15 10:40 ` Jani Nikula
2025-12-15 9:49 ` ✗ CI.checksparse: warning for " Patchwork
2025-12-15 9:50 ` Nilawar, Badal [this message]
2025-12-15 10:37 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-12-15 12:12 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d38da8-3591-4e80-a19d-0e15aad41710@intel.com \
--to=badal.nilawar@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox