From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5611C25B7C for ; Tue, 28 May 2024 12:41:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BA49112269; Tue, 28 May 2024 12:41:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CDk4g+fc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8E7211226C for ; Tue, 28 May 2024 12:41:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716900088; x=1748436088; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=usrCLmaYqlT32jUD4AkXkE0s2hZNyH+voouYLXTwnMo=; b=CDk4g+fcVg5CKbnYZFQ40JskYh93Xf0zW5RveCnXdnZuTmmdPHbQ30oQ 11iUTgK7ceP45D8jjjsrYl6bR74BeHoKbpV5fMMPmYbFUjjUvI4/23wj/ JEkBOOBCGyr1os/qxLbXhoztNTuPx9JtePnhdz7Dp7wBt9UdEu/+QxP52 /G46AtCraizrqBsSQLi2L0mZJ6x2Rg1Btgq5kdIMuV2FtdUMIvSZrjUeK nUoIjfVYQ9UELtl8xDcmLTGPBFiB4UJplHZ700B7xocYSyUEaqLeEUpu7 tKwMbmxC9dVzBnerpcURIoCT2g5yoWMRFEuljHtc3gJ4LKM7nn5fjyDxa A==; X-CSE-ConnectionGUID: oNJVCI3iSUq41/p7Jy6j8g== X-CSE-MsgGUID: izQ1ds6YQMuH/Ain/+NH0A== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="13370582" X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="13370582" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 05:41:22 -0700 X-CSE-ConnectionGUID: tDD6MLGKR++8OMz2+Fy/Ow== X-CSE-MsgGUID: NqH3DDEESdG4tCKrh97nIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="58243325" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.94.250.54]) ([10.94.250.54]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 05:41:20 -0700 Message-ID: <6661307b-9ae7-42a9-9077-483aa43d550c@linux.intel.com> Date: Tue, 28 May 2024 14:41:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/xe: flush gtt before signalling user fence on all engines To: Andrzej Hajda , intel-xe@lists.freedesktop.org Cc: Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Maarten Lankhorst , Matthew Auld , Matthew Brost References: <20240522-xu_flush_vcs_before_ufence-v2-1-9ac3e9af0323@intel.com> <03a44fa0-c187-4c8a-95c7-1dd6e1f14eab@intel.com> Content-Language: en-US From: Nirmoy Das In-Reply-To: <03a44fa0-c187-4c8a-95c7-1dd6e1f14eab@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 5/28/2024 1:35 PM, Andrzej Hajda wrote: > On 22.05.2024 09:27, Andrzej Hajda wrote: >> Tests show that user fence signalling requires kind of write barrier, >> otherwise not all writes performed by the workload will be available >> to userspace. It is already done for render and compute, we need it >> also for the rest: video, gsc, copy. >> >> v2: added gsc and copy engines, added fixes and r-b tags >> >> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1488 >> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel >> GPUs") >> Signed-off-by: Andrzej Hajda >> Reviewed-by: Matthew Brost >> --- > > Gently ping. > The patch is reviewed, needs just merging :) Merged to drm-xe-next. Thanks, Nirmoy > > Regards > Andrzej > >> Changes in v2: >> - Added fixes and r-b tags >> - Link to v1: >> https://lore.kernel.org/r/20240521-xu_flush_vcs_before_ufence-v1-1-ded38b56c8c9@intel.com >> --- >> Matthew, >> >> I have extended patch to copy and gsc engines. I have kept your r-b, >> since the change is similar, I hope it is OK. >> --- >>   drivers/gpu/drm/xe/xe_ring_ops.c | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c >> b/drivers/gpu/drm/xe/xe_ring_ops.c >> index a3ca718456f6..a46a1257a24f 100644 >> --- a/drivers/gpu/drm/xe/xe_ring_ops.c >> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c >> @@ -234,13 +234,13 @@ static void __emit_job_gen12_simple(struct >> xe_sched_job *job, struct xe_lrc *lrc >>         i = emit_bb_start(batch_addr, ppgtt_flag, dw, i); >>   +    i = emit_flush_imm_ggtt(xe_lrc_seqno_ggtt_addr(lrc), seqno, >> false, dw, i); >> + >>       if (job->user_fence.used) >>           i = emit_store_imm_ppgtt_posted(job->user_fence.addr, >>                           job->user_fence.value, >>                           dw, i); >>   -    i = emit_flush_imm_ggtt(xe_lrc_seqno_ggtt_addr(lrc), seqno, >> false, dw, i); >> - >>       i = emit_user_interrupt(dw, i); >>         xe_gt_assert(gt, i <= MAX_JOB_SIZE_DW); >> @@ -293,13 +293,13 @@ static void __emit_job_gen12_video(struct >> xe_sched_job *job, struct xe_lrc *lrc, >>         i = emit_bb_start(batch_addr, ppgtt_flag, dw, i); >>   +    i = emit_flush_imm_ggtt(xe_lrc_seqno_ggtt_addr(lrc), seqno, >> false, dw, i); >> + >>       if (job->user_fence.used) >>           i = emit_store_imm_ppgtt_posted(job->user_fence.addr, >>                           job->user_fence.value, >>                           dw, i); >>   -    i = emit_flush_imm_ggtt(xe_lrc_seqno_ggtt_addr(lrc), seqno, >> false, dw, i); >> - >>       i = emit_user_interrupt(dw, i); >>         xe_gt_assert(gt, i <= MAX_JOB_SIZE_DW); >> >> --- >> base-commit: 188ced1e0ff892f0948f20480e2e0122380ae46d >> change-id: 20240521-xu_flush_vcs_before_ufence-a7b45d94cf33 >> >> Best regards, >