From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19C38EC1123 for ; Mon, 23 Feb 2026 19:18:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC7AB10E435; Mon, 23 Feb 2026 19:18:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="lgzFKgij"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD0D610E42E; Mon, 23 Feb 2026 19:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771874335; x=1803410335; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vwdBKJfg0FxkKOyrRNVzO7SdSlXi3w3RWQk5zuuNWos=; b=lgzFKgijG6tnfa2KwNQhVh5y4kbRp14rHesYgGPL6uXdRKRqwMf9NuVj OBgrhEUQlYI0qeen327dxTUOInTsanRr+QlRJ48XLv+kTXNYEjJ8HbOGo qi95ieRYRdR9AWlNUksM50KjTY57wP5qNiZZ4aRVsv2vFsFLLSrBpivm+ pV8h1GfceJk8JLSQ8Yw8stErWsWryo1ap+74np9UT+fqQwYofCZ4jsinc Vm4FaVq0XcaU98Wpb88vZ4tbfv3oXI/Tdj2/fWsoP4tvwowBFSpxLUTR+ fuMsN+ZJ+AC54Ap8vKG4KWUVFVi+aU3kjhBFIJJ8otiy3Gt0WhtNpDmtM w==; X-CSE-ConnectionGUID: c/r277uyRmKwyq+Ha81WKw== X-CSE-MsgGUID: o7wniQwGR9qv+kMFnWuanw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="83202148" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="83202148" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 11:18:55 -0800 X-CSE-ConnectionGUID: VtqbLv9bRiCvVbFb9mCjtg== X-CSE-MsgGUID: MqAO6EX0TkK0bYnhGLf0Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="213976768" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO [10.245.244.65]) ([10.245.244.65]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 11:18:53 -0800 Message-ID: <666476e1-3cfb-4574-af74-b9feda2d57ca@linux.intel.com> Date: Mon, 23 Feb 2026 20:18:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc To: Matthew Brost , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: matthew.auld@intel.com References: <20260219205029.1011336-1-matthew.brost@intel.com> Content-Language: en-US From: Maarten Lankhorst In-Reply-To: <20260219205029.1011336-1-matthew.brost@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hey, Den 2026-02-19 kl. 21:50, skrev Matthew Brost: > The kernel-doc for drm_gpusvm_pages_valid_unlocked() was stale and still > referenced old range-based arguments and naming. Update the documentation > to match the current function arguments and signature. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/drm_gpusvm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c > index 81626b00b755..2e229bc944f0 100644 > --- a/drivers/gpu/drm/drm_gpusvm.c > +++ b/drivers/gpu/drm/drm_gpusvm.c > @@ -1338,14 +1338,14 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm, > EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid); > > /** > - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked > + * drm_gpusvm_pages_valid_unlocked() - GPU SVM pages valid unlocked > * @gpusvm: Pointer to the GPU SVM structure > - * @range: Pointer to the GPU SVM range structure > + * @svm_pages: Pointer to the GPU SVM pages structure > * > - * This function determines if a GPU SVM range pages are valid. Expected be > - * called without holding gpusvm->notifier_lock. > + * This function determines if a GPU SVM pages are valid. Expected be called > + * without holding gpusvm->notifier_lock. > * > - * Return: True if GPU SVM range has valid pages, False otherwise > + * Return: True if GPU SVM pages are valid, False otherwise > */ > static bool drm_gpusvm_pages_valid_unlocked(struct drm_gpusvm *gpusvm, > struct drm_gpusvm_pages *svm_pages) Reviewed-by: Maarten Lankhorst