Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	saurabhg.gupta@intel.com, alex.zuo@intel.com,
	joonas.lahtinen@intel.com, lucas.demarchi@intel.com,
	matthew.brost@intel.com, kernel-dev@igalia.com,
	Tvrtko Ursulin <tursulin@igalia.com>
Subject: Re: [PATCH 0/4] drm/xe/xe_drm_client: Add per drm client reset stats
Date: Tue, 18 Feb 2025 16:21:15 -0300	[thread overview]
Message-ID: <67298861-0a4e-4094-a948-cfdfb0a97a83@igalia.com> (raw)
In-Reply-To: <20250214203757.27895-1-jonathan.cavitt@intel.com>

Hi Jonathan,

Em 14/02/2025 17:37, Jonathan Cavitt escreveu:
> Add additional information to drm client so it can report the last 50
> exec queues to have been banned on it, as well as the last pagefault
> seen when said exec queues were banned. Since we cannot reasonably
> associate a pagefault to a specific exec queue, we currently report the
> last seen pagefault on the associated hw engine instead.
> 
> The last pagefault seen per exec queue is saved to the hw engine, and the
> pagefault is updated during the pagefault handling process in
> xe_gt_pagefault. The last seen pagefault is reset when the engine is
> reset because any future exec queue bans likely were not caused by said
> pagefault after the reset.
> 
> Also add a tracker that counts the number of times the drm client has
> experienced an engine reset.

What's the use case for this? How will userspace consume this information?

> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> 
> Jonathan Cavitt (4):
>    drm/xe/xe_exec_queue: Add ID param to exec queue struct
>    drm/xe/xe_gt_pagefault: Migrate pagefault struct to header
>    FIXME: drm/xe/xe_drm_client: Add per drm client pagefault info
>    drm/xe/xe_drm_client: Add per drm client reset stats
> 
>   drivers/gpu/drm/xe/xe_drm_client.c       | 130 +++++++++++++++++++++++
>   drivers/gpu/drm/xe/xe_drm_client.h       |  38 +++++++
>   drivers/gpu/drm/xe/xe_exec_queue.c       |   8 ++
>   drivers/gpu/drm/xe/xe_exec_queue_types.h |   2 +
>   drivers/gpu/drm/xe/xe_gt_pagefault.c     |  46 ++++----
>   drivers/gpu/drm/xe/xe_gt_pagefault.h     |  51 +++++++++
>   drivers/gpu/drm/xe/xe_guc_submit.c       |  19 ++++
>   drivers/gpu/drm/xe/xe_hw_engine.c        |   4 +
>   drivers/gpu/drm/xe/xe_hw_engine_types.h  |   8 ++
>   9 files changed, 279 insertions(+), 27 deletions(-)
> 


      parent reply	other threads:[~2025-02-18 19:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 20:37 [PATCH 0/4] drm/xe/xe_drm_client: Add per drm client reset stats Jonathan Cavitt
2025-02-14 20:37 ` [PATCH 1/4] drm/xe/xe_exec_queue: Add ID param to exec queue struct Jonathan Cavitt
2025-02-14 20:37 ` [PATCH 2/4] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header Jonathan Cavitt
2025-02-14 20:37 ` [PATCH 3/4] FIXME: drm/xe/xe_drm_client: Add per drm client pagefault info Jonathan Cavitt
2025-02-16  4:04   ` kernel test robot
2025-02-17 17:01   ` Simona Vetter
2025-02-18 15:11     ` Cavitt, Jonathan
2025-02-18 18:39     ` Tvrtko Ursulin
2025-02-18 20:40       ` Cavitt, Jonathan
2025-02-19 13:44         ` Simona Vetter
2025-02-14 20:37 ` [PATCH 4/4] drm/xe/xe_drm_client: Add per drm client reset stats Jonathan Cavitt
2025-02-18 18:45   ` Tvrtko Ursulin
2025-02-19 13:45     ` Simona Vetter
2025-02-14 20:48 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-14 20:48 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-14 20:50 ` ✓ CI.KUnit: success " Patchwork
2025-02-14 21:13 ` ✓ CI.Build: " Patchwork
2025-02-14 21:15 ` ✓ CI.Hooks: " Patchwork
2025-02-14 21:17 ` ✓ CI.checksparse: " Patchwork
2025-02-14 21:43 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-02-15 21:00 ` ✗ Xe.CI.Full: " Patchwork
2025-02-18 19:21 ` André Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67298861-0a4e-4094-a948-cfdfb0a97a83@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=alex.zuo@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=joonas.lahtinen@intel.com \
    --cc=kernel-dev@igalia.com \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=tursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox