From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 854C8EC1420 for ; Tue, 3 Mar 2026 10:25:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A4E710E178; Tue, 3 Mar 2026 10:25:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eC1O6WdY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97CF210E178; Tue, 3 Mar 2026 10:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772533559; x=1804069559; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=njApmznPEAadkHWt/cCZ/YNP28SQsDt0VzdlUQ21HIQ=; b=eC1O6WdYqCj1OJrKUlpeMkjs0F/5biu++fA0u2LG/yIy4nD5rPgbEuls OPK5OOjTQUUUvtUK8GPyg/AEjhTzZ34CIUu882VEAjdcGm+T16lxdIhlg vM1omO2jAuxpxftD13Rn/pWnZ0ey0000AzMB1I+e9sKroUSsN/tZ+D89a pU5rGo1rFXOCz7LTe9hwj7pIZmdFlqglVXUGchTsEEQkyK0EGpDU+Cjbe hQiR/7BYFS19oxgzu2cX1MItC3L5DdRPILkdGBKAPvMVi57pAUabbwZU2 S4S6rm0HJk/BPK27oxH/yul3NQsxXdcQoi4KbU8GNQ1SNb3hSL5ZvIbzU A==; X-CSE-ConnectionGUID: c6m3ZYSVQJSepiWI+PteMQ== X-CSE-MsgGUID: RNzms6k8Tzque5OTNEW3/A== X-IronPort-AV: E=McAfee;i="6800,10657,11717"; a="99042325" X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="99042325" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 02:25:58 -0800 X-CSE-ConnectionGUID: tpvxLQsVTuqtmIG9LvGxcA== X-CSE-MsgGUID: 7a5wuDmuQdCBfEqtXQi5RA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="217942870" Received: from administrator-system-product-name.igk.intel.com ([10.91.214.181]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 02:25:57 -0800 Date: Tue, 3 Mar 2026 11:25:55 +0100 (CET) From: =?ISO-8859-2?Q?Micha=B3_Grzelak?= To: Ville Syrjala cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/overlay: Fix oops on unload In-Reply-To: <20260303101417.14409-1-ville.syrjala@linux.intel.com> Message-ID: <67e4ef68-268c-57ad-1abd-5c07cefd6270@intel.com> References: <20260303101417.14409-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1527428566-1991801551-1772533557=:1845334" X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1527428566-1991801551-1772533557=:1845334 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 3 Mar 2026, Ville Syrjala wrote: > From: Ville Syrjälä > > Apparently I failed to test the unload case properly and > thus didn't notice that the i915_overlay_is_active() needs > i915->overlay after fetch_and_zero() already cleared it. > Stop using fetch_and_zero() and only clear the pointer at > the end to avoid the oops. > > Fixes: 38d9a352c45e ("drm/i915/overlay: Extract i915_overlay_is_active()") > Signed-off-by: Ville Syrjälä Reviewed-by: Michał Grzelak BR, Michał --1527428566-1991801551-1772533557=:1845334--