Re: [PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 6/3/2026 2:24 AM, Juasheem Sultan wrote:
> VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry Format)
> unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
> state mismatches during state readout because the VSC SDP state is not
> properly recovered when Panel Replay is active with colorimetry.
> 
> Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
> so that the state is correctly recovered.
> 
> v2: Rebase onto latest upstream
> v3: Fix git commit description
> 

LGTM.
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
> Cc: Gil Dekel <gildekel@google.com>
> Signed-off-by: Juasheem Sultan <jdsultan@google.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 6ef2a0043cda..b8746dab051c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5343,11 +5343,15 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
>   		 *   VSC SDP supporting 3D stereo + Panel Replay.
>   		 */
>   		return 0;
> -	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 == 0x13) {
> +	} else if ((sdp->sdp_header.HB2 == 0x5 || sdp->sdp_header.HB2 == 0x7) &&
> +			sdp->sdp_header.HB3 == 0x13) {
>   		/*
>   		 * - HB2 = 0x5, HB3 = 0x13
>   		 *   VSC SDP supporting 3D stereo + PSR2 + Pixel Encoding/Colorimetry
>   		 *   Format.
> +		 * - HB2 = 0x7, HB3 = 0x13
> +		 *   VSC SDP supporting 3D stereo + Panel Replay + Pixel Encoding/Colorimetry
> +		 *   Format.
>   		 */
>   		vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
>   		vsc->colorimetry = sdp->db[16] & 0xf;