Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Varun Gupta <varun.gupta@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, matthew.brost@intel.com,
	 arvind.yadav@intel.com, himal.prasad.ghimiray@intel.com
Subject: Re: [PATCH] drm/pagemap: Drop ratelimiting from dev_unhold_work debug trace
Date: Wed, 23 Sep 2026 09:54:26 +0200	[thread overview]
Message-ID: <6aefc78b4a0e5a16084c67bb22e6eada9974b363.camel@linux.intel.com> (raw)
In-Reply-To: <20260921062648.1166903-2-varun.gupta@intel.com>

On Mon, 2026-09-21 at 11:56 +0530, Varun Gupta wrote:
> Reference-drop trace in drm_pagemap_dev_unhold_work() was changed
> from drm_dbg() to drm_dbg_ratelimited() to reduce serial console
> bottlenecks.
> However, when the ratelimit kicks in, the kernel's ratelimiting
> subsystem
> logs a "callbacks suppressed" notification at the KERN_WARNING level.
> Revert the trace macro back to drm_dbg()
> 
> Fixes: b66b036c959f ("drm/pagemap: Prevent CPU stalls during
> unbounded pagemap teardown")
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_pagemap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_pagemap.c
> b/drivers/gpu/drm/drm_pagemap.c
> index 0867bfbde5c5..ba97daedcd49 100644
> --- a/drivers/gpu/drm/drm_pagemap.c
> +++ b/drivers/gpu/drm/drm_pagemap.c
> @@ -1009,7 +1009,7 @@ static void drm_pagemap_dev_unhold_work(struct
> work_struct *work)
>  		struct drm_device *drm = dev_hold->drm;
>  		struct module *module = drm->driver->fops->owner;
>  
> -		drm_dbg_ratelimited(drm, "Releasing reference on
> provider device and module.\n");
> +		drm_dbg(drm, "Releasing reference on provider device
> and module.\n");
>  		drm_dev_put(drm);
>  		module_put(module);
>  		kfree(dev_hold);

      parent reply	other threads:[~2026-09-23  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  6:26 [PATCH] drm/pagemap: Drop ratelimiting from dev_unhold_work debug trace Varun Gupta
2026-09-21  6:33 ` sashiko-bot
2026-09-23  8:39   ` Gupta, Varun
2026-09-21  7:25 ` ✓ CI.KUnit: success for " Patchwork
2026-09-21  8:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-21 11:25 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-23  7:54 ` Thomas Hellström [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6aefc78b4a0e5a16084c67bb22e6eada9974b363.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=arvind.yadav@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=varun.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox