Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	maarten.lankhorst@linux.intel.com,
	Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: [PATCH 4/4] drm/i915/display: debug log about fence wait errors
Date: Thu, 10 Sep 2026 22:42:36 +0300	[thread overview]
Message-ID: <6b670a146bfcfd0cc2c7641cc8d72df96e356ef9.1789069102.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1789069102.git.jani.nikula@intel.com>

Currently there's no indication if fence wait failed. Debug log about
it.

v2: Rebase, no timeout anymore

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 983e84bca1ee..edaa29944d23 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7290,6 +7290,7 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)
 
 static void intel_atomic_commit_fence_wait(struct intel_atomic_state *state)
 {
+	struct intel_display *display = to_intel_display(state);
 	struct drm_plane *plane;
 	struct drm_plane_state *new_plane_state;
 	long ret;
@@ -7300,8 +7301,11 @@ static void intel_atomic_commit_fence_wait(struct intel_atomic_state *state)
 			continue;
 
 		ret = dma_fence_wait(new_plane_state->fence, false);
-		if (ret < 0)
+		if (ret < 0) {
+			drm_dbg_kms(display->drm, "[PLANE:%d:%s] fence wait failed (%pe)\n",
+				    plane->base.id, plane->name, ERR_PTR(ret));
 			break;
+		}
 
 		dma_fence_put(new_plane_state->fence);
 		new_plane_state->fence = NULL;
-- 
2.47.3


  parent reply	other threads:[~2026-09-10 19:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 19:42 [PATCH 0/4] drm/i915/display: stop using the configurable fence timeout, cleanups Jani Nikula
2026-09-10 19:42 ` [PATCH 1/4] drm/i915/display: stop using the configurable fence timeout Jani Nikula
2026-09-10 19:42 ` [PATCH 2/4] drm/i915/display: use struct intel_atomic_state *state variable naming Jani Nikula
2026-09-10 19:42 ` [PATCH 3/4] drm/i915/display: reduce indent in intel_atomic_commit_fence_wait() Jani Nikula
2026-09-10 19:42 ` Jani Nikula [this message]
2026-09-10 19:49 ` ✗ CI.checkpatch: warning for drm/i915/display: stop using the configurable fence timeout, cleanups Patchwork
2026-09-10 19:51 ` ✓ CI.KUnit: success " Patchwork
2026-09-10 20:35 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-11  5:58 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b670a146bfcfd0cc2c7641cc8d72df96e356ef9.1789069102.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox