Re: [PATCH v3 3/6] drm/xe/cper: Emit software CPER records

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 10-11-2026 08:42 pm, Nilawar, Badal wrote:
>
> On 05-11-2026 14:23, Mallesh Koujalagi wrote:
>> Emit CPER records for software SIGIDs and attach the
>> formatted log message as record data.
>>
>> Cc: Badal Nilawar <badal.nilawar@intel.com>
>> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_cper.c       | 12 ++++++++++++
>>   drivers/gpu/drm/xe/xe_cper_types.h |  4 ++++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_cper.c b/drivers/gpu/drm/xe/xe_cper.c
>> index 10aa10bbf282..9510dcd1754c 100644
>> --- a/drivers/gpu/drm/xe/xe_cper.c
>> +++ b/drivers/gpu/drm/xe/xe_cper.c
>> @@ -248,6 +248,13 @@ static void cper_emit_hw_err(struct xe_device 
>> *xe, int cper_sev, enum xe_sigid s
>>       xe_cper_emit_counter(xe, cper_sev, sigid, counter, &response);
>>   }
>>   +#define XE_CPER_SW_MSG_MAX    256
>> +
>> +static size_t cper_format_sw_msg(struct va_format *vaf, char *buf, 
>> size_t size)
>> +{
>> +    return scnprintf(buf, size, "%pV", vaf) + 1;
>> +}
>> +
>>   static void cper_emit_sw_err(struct xe_device *xe, int cper_sev, 
>> enum xe_sigid sigid,
>>                    u32 component, u32 location, const void *data,
>>                    struct va_format *vaf)
>> @@ -256,6 +263,8 @@ static void cper_emit_sw_err(struct xe_device 
>> *xe, int cper_sev, enum xe_sigid s
>>       struct xe_cper_intel_hdr ihdr = {};
>>       struct xe_cper_driver_error_class *driver = &error_class.driver;
>>       u64 timestamp = ktime_get_boottime_ns();
>> +    char msg[XE_CPER_SW_MSG_MAX];
>> +    size_t msg_len;
>>         driver->error_type = cper_sev;
>>       driver->error_component = component;
>> @@ -263,7 +272,10 @@ static void cper_emit_sw_err(struct xe_device 
>> *xe, int cper_sev, enum xe_sigid s
>>       if (IS_ERR(data))
>>           driver->cause = -PTR_ERR(data);
>>   +    msg_len = cper_format_sw_msg(vaf, msg, sizeof(msg));
>> +
>>       cper_init_intel_hdr(xe, &error_class, timestamp, sigid, 1, &ihdr);
>> +    cper_record_emit(xe, cper_sev, &INTEL_CPER_NOTIFY_DRV_ERROR, 
>> &ihdr, msg, msg_len);
>
> xe_cper_driver_error_class already contains the necessary information. 
> Why does <msg> need to be passed to CPER record?

Discussed with Arch team, along with xe_cper_driver_error_class info, we 
need to emit <msg> in case of software CPER.

Thanks,

-/Mallesh

>
> Thanks,
> Badal
>
>>   }
>>     /**
>> diff --git a/drivers/gpu/drm/xe/xe_cper_types.h 
>> b/drivers/gpu/drm/xe/xe_cper_types.h
>> index d8581992dc45..268995a537c4 100644
>> --- a/drivers/gpu/drm/xe/xe_cper_types.h
>> +++ b/drivers/gpu/drm/xe/xe_cper_types.h
>> @@ -40,6 +40,10 @@
>>       GUID_INIT(0x4ae12aef, 0x8745, 0x5fc7, \
>>             0xb9, 0x96, 0x71, 0xee, 0xbb, 0x51, 0xf2, 0x23)
>>   +#define INTEL_CPER_NOTIFY_DRV_ERROR \
>> +    GUID_INIT(0xcef7e934, 0x51e7, 0x535f, \
>> +          0xa6, 0x78, 0x5a, 0x4c, 0xcc, 0xb6, 0x96, 0x09)
>> +
>>   /* Section Types */
>>   #define INTEL_CPER_SECTION_ACCEL_GENERIC \
>>       GUID_INIT(0xea9d8f84, 0x4258, 0x5227, \