Re: [PATCH 2/2] drm/xe/ras: Report internal HW errors from PUNIT

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]


On 19-08-2026 04:47 am, Umesh Nerlige Ramappa wrote:
> Report internal HW errors from PUNIT using the xe_log_comp() helper. Since
> the error results in a wedge, use CPER_SEV_FATAL as the severity.
>
> Signed-off-by: Umesh Nerlige Ramappa<umesh.nerlige.ramappa@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ras.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> index 13ae54afedf7..aa790571f716 100644
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c
> @@ -353,9 +353,10 @@ static u8 handle_soc_internal_errors(struct xe_device *xe, struct xe_ras_error_a
>   		struct xe_ras_ieh_error *ieh_error = (void *)info->details;
>   
>   		if (ieh_error->global_error_status & XE_RAS_SOC_IEH_PUNIT) {
> -			xe_err(xe, "[RAS]: PUNIT %s detected: 0x%x\n",
> -			       sev_to_str(counter->common.severity),
> -			       ieh_error->global_error_status);
> +			xe_log_comp(xe, CPER_SEV_FATAL, SOC_INTERNAL, counter, sizeof(*counter),

Please do n't hardcore severity, use counter->common.severityone.

For cper preparation, we need counter+response, need to confirm from @ 
Badal.

> +				    "PUNIT %s detected: 0x%x\n",
> +				    sev_to_str(counter->common.severity),

drop severity.

Thanks,

-/Mallesh

> +				    ieh_error->global_error_status);
>   			punit_error_handler(xe);
>   			return XE_RAS_RECOVERY_ACTION_DISCONNECT;
>   		}

[-- Attachment #2: Type: text/html, Size: 2355 bytes --]