Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jocelyn Falempe <jfalempe@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	jani.nikula@linux.intel.com, rodrigo.vivi@intel.com,
	joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
	lucas.demarchi@intel.com, thomas.hellstrom@linux.intel.com,
	simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org,
	maarten.lankhorst@linux.intel.com, javierm@redhat.com
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/12] drm/{i915,xe}: Run DRM default client setup
Date: Tue, 7 Jan 2025 16:18:31 +0100	[thread overview]
Message-ID: <6f46535b-1075-4ac7-8809-274dffada2c8@redhat.com> (raw)
In-Reply-To: <332ba13f-8dd8-4195-9af2-26b1f18cf1c8@suse.de>

On 07/01/2025 15:42, Thomas Zimmermann wrote:
> Hi Jocelyn
> 
> 
> Am 07.01.25 um 13:10 schrieb Jocelyn Falempe:
>> On 12/12/2024 18:08, Thomas Zimmermann wrote:
>>> Rework fbdev probing to support fbdev_probe in struct drm_driver
>>> and remove the old fb_probe callback. Provide an initializer macro
>>> that sets the callback in struct drm_driver according to the kernel
>>> configuration. Call drm_client_setup_with_color_mode() to run the
>>> kernel's default client setup for DRM.
>>>
>>> This commit also prepares support for the kernel's drm_log client
>>> (or any future client) in i915. Using drm_log will also require vmap
>>> support in GEM objects.
>>
>> I've tested this series on an Alderlake laptop, and it effectively 
>> breaks the boot with drm_log on i915. (I can still see the drm_log on 
>> simpledrm, but when it switches to i915, I get a blackscreen, and the 
>> laptop hard freezes).
>> Can we wait to have the proper vmap support in GEM objects, before 
>> merging this series?
>> Or at least prevent drm_log to load on i915, until it is fixed?
> 
> Did you add vmap support as advised here? i915 will not support drm_log 
> without and this series does not add it.
> 
> A patch for vmap functions is at [1], I think.

Thanks a lot, it works much better with this patch :)
That was the missing piece to have drm_log display something on i915.

Best regards,

-- 

Jocelyn

> 
> Best regards
> Thomas
> 
> [1] https://patchwork.freedesktop.org/series/135554/
> 
> 
>>
>> Best regards,
>>
> 


  reply	other threads:[~2025-01-07 15:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 17:08 [PATCH 00/12] drm/{i915,xe}: Convert to DRM client setup Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 01/12] drm/{i915, xe}: Suspend/resume fbdev emulation via client interfaces Thomas Zimmermann
2025-02-11 20:55   ` Rodrigo Vivi
2025-02-12  7:43     ` Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 02/12] drm/client: Add client-hotplug helper Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 03/12] drm/client: Send pending hotplug events after resume Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 04/12] drm/i915/display: Remove fbdev suspend and hotplug tracking Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 05/12] drm/i915/display: fbdev: Move custom restore code to new callback Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 06/12] drm/i915/display: fbdev: Move custom suspend " Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 07/12] drm/i915/display: Remove preferred_bpp from struct intel_fbdev Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 08/12] drm/i915/display: Remove struct drm_fb_helper " Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 09/12] drm/i915/display: Move fbdev code around Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 10/12] drm/{i915,xe}: Run DRM default client setup Thomas Zimmermann
2025-01-07 12:10   ` Jocelyn Falempe
2025-01-07 14:42     ` Thomas Zimmermann
2025-01-07 15:18       ` Jocelyn Falempe [this message]
2024-12-12 17:08 ` [PATCH 11/12] drm/i915/display: Remove compile guard around fbdev debugfs output Thomas Zimmermann
2024-12-12 17:08 ` [PATCH 12/12] drm/fb-helper: Remove struct drm_fb_helper.fb_probe Thomas Zimmermann
2024-12-12 17:53 ` ✓ CI.Patch_applied: success for drm/{i915,xe}: Convert to DRM client setup Patchwork
2024-12-12 17:53 ` ✓ CI.checkpatch: " Patchwork
2024-12-12 17:55 ` ✓ CI.KUnit: " Patchwork
2024-12-12 18:13 ` ✓ CI.Build: " Patchwork
2024-12-12 18:15 ` ✓ CI.Hooks: " Patchwork
2024-12-12 18:17 ` ✗ CI.checksparse: warning " Patchwork
2024-12-12 18:47 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-12 23:18 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-07  9:07 ` [PATCH 00/12] " Thomas Zimmermann
2025-02-11  7:17 ` Thomas Zimmermann
2025-02-12  7:28   ` Maarten Lankhorst
2025-02-12  7:42     ` Thomas Zimmermann
2025-02-28  8:49     ` Thomas Zimmermann
2025-03-04 19:40       ` Maarten Lankhorst
2025-03-04 21:38         ` Jocelyn Falempe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f46535b-1075-4ac7-8809-274dffada2c8@redhat.com \
    --to=jfalempe@redhat.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox