Re: [PATCH 0/9] Don't whitelist OA registers unconditionally

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1819 bytes --]

On 5/18/26 19:47, Ashutosh Dixit wrote:
> Whitelisting OA registers unconditionally is a security violation. In this
> series we resolve this issue as follows:
> 
> * Set the 'deny' bit (bit 30) for all OA registers, ensuring OA registers
>   are not whitelisted by default after probe/reset/restart
> * Reset the 'deny' bit when an OA stream is opened and certain conditions
>   are met, whitelisting OA registers only for the duration when OA streams
>   are open for a gt
> * Set the 'deny' bit again, when OA streams are closed
> * To manage this scheme, separate out OA whitelists from non-OA whitelists
>   (into separate save-restore lists)
> 
> Ashutosh Dixit (9):
>   drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelists
>   drm/xe/rtp: Maintain OA whitelists separately
>   drm/xe/rtp: Keep track of non-OA nonpriv slots
>   drm/xe/rtp: Generalize whitelist_apply_to_hwe
>   drm/xe/rtp: Save OA nonpriv registers to register save/restore lists
>   drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regs
>   drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gt
>   drm/xe/oa: (De-)whitelist OA registers on OA stream open/release
>   drm/xe/rtp: Ensure locking/ref counting for OA whitelists
> 
>  drivers/gpu/drm/xe/xe_gt_debugfs.c      |  4 +-
>  drivers/gpu/drm/xe/xe_hw_engine.c       |  2 +
>  drivers/gpu/drm/xe/xe_hw_engine_types.h |  8 +++
>  drivers/gpu/drm/xe/xe_oa.c              |  7 ++
>  drivers/gpu/drm/xe/xe_oa_types.h        |  3 +
>  drivers/gpu/drm/xe/xe_reg_whitelist.c   | 92 ++++++++++++++++++++++---
>  drivers/gpu/drm/xe/xe_reg_whitelist.h   |  4 ++
>  7 files changed, 111 insertions(+), 9 deletions(-)
> 

Does this (and any other potential security issues) need to be Cc: stable?
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]