From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD23BCD128A for ; Tue, 9 Apr 2024 15:37:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46CA910E17F; Tue, 9 Apr 2024 15:37:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iVoJKRkX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0DC410E87B for ; Tue, 9 Apr 2024 15:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712677073; x=1744213073; h=message-id:date:subject:to:references:from:in-reply-to: mime-version; bh=Zw4i9aF4i6Rr5N3h2LEBTJo0aCJ8ARjebboXgJKjDsM=; b=iVoJKRkXLaYMCx81wwADf8+xq5VG244U8tMqZIjjvjZ8WONpUa/GX3Xl 8ix/dCAfmLokuNEUXLkEMm+4G+1w2codKnmbo3p8YyFmuEl0JN7WqWpym 2++Yp8ziRBQiY4BveC/HLTpEBmhdWf682rhDAYavPdVvOOoa7cp+AXSMx AF1BNOVKdPIWeuGXFmKdSBxiLdblxO6WOPlEv/BG8KnI9hFSlc81rYzmj 0+JKao5vR1yzDM2mJ+vWadhoH+YGQTGL+gV/eP/vjvWk1FygyvXk9k9jZ gNFAUxkX1Hyy9d7Xbd2+KLkSHD5ALm8w5jFu0uI/24DiJRW6Wp0exCgDK w==; X-CSE-ConnectionGUID: uhoO8iLuQgqQeCQQra6zng== X-CSE-MsgGUID: C8SMTgMOR9a985FtKQrI6w== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="11839404" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208,217";a="11839404" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 08:37:52 -0700 X-CSE-ConnectionGUID: nSzYxXBmRdOoaKgHMklTrA== X-CSE-MsgGUID: /tCS95qeRxqH0AXxBCFvAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208,217";a="20378592" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Apr 2024 08:37:44 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Apr 2024 08:37:37 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Apr 2024 08:37:37 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Apr 2024 08:37:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/X8L/t6vMigWIO/cyQY8HV0TUx7bFLQ6L7ohtYyGaD15H7rD4uLSMhAIpRQuEp91L2cEOX6fwsMj5fJi1mgStlaZAMPDOmMSHbRNWHuex5mePbIO390RNQwvVtBRU6Iu/Yikp+hun3TlXYyF61keVeOBDxB0tj5wGFcELL2mERArKs8L0i3DIpgum/zMTJfmeYWJQls1sSws/+Caw1a3h2LyAd0wNQakFDm8Hme74qzejvi39vpWAbjEX2CyoJ2dVgk1qHE4APXT95YHZLAC01WE1dcXzwI5Kt77hh8DZthe7m6l7XnJKkAMvcI3di8hiv1uWI6KxqbBdXIoUxcYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdv8xTbT2uih24BKF/wkHpkNh1PBvxomeW2bp2U0w6E=; b=bPsJQEAd5FiEPZ3ERFf/jNzDicnoHk8wd6/UJdTwzGAfA2rYYzGxuEfuUBLwlxpPLU5+Ua8YImgsUAyO09jC3iLxWtYtvjyjwS62K6CBwNO604+CI0IQaGkgKyB/13cJS6QmKfE07f2ncmUqAEXzEf7lJY6VyBTP14GhmVHZTefbsK9d1fK0iCBuTsr+psY+Dx2TvdSKcJ6hzOMVlXUNFEgqf+KxllYSWmfNTRECdcdrMQNdR76tAGU4skfmSAdsMQdXUpv/Lu7rATjFNGrQY+7dAT4wNvABxcG8zOc3+YntC+yUVj7ceOAvtr3VT3oTS+LO2XyTbZLx0tOVix/sEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) by SJ0PR11MB8293.namprd11.prod.outlook.com (2603:10b6:a03:44f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Tue, 9 Apr 2024 15:37:34 +0000 Received: from MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::8664:8749:8357:f11a]) by MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::8664:8749:8357:f11a%7]) with mapi id 15.20.7452.019; Tue, 9 Apr 2024 15:37:34 +0000 Content-Type: multipart/alternative; boundary="------------Ry7dj33dL23jqi0qo0j8QUdq" Message-ID: <745b0aff-ff45-4aa7-84c2-a7c9260aa3ab@intel.com> Date: Tue, 9 Apr 2024 21:07:29 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/xe: Check result of drmm_mutex_init() To: References: <20240409153132.1111-1-michal.wajdeczko@intel.com> Content-Language: en-US From: "Ghimiray, Himal Prasad" In-Reply-To: <20240409153132.1111-1-michal.wajdeczko@intel.com> X-ClientProxiedBy: PN3PR01CA0188.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:be::20) To MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB7056:EE_|SJ0PR11MB8293:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DcMiB1Z9Wl+6OJLIRLZAkcxK2t/seZ2hGlPSMFiD2x9HoP/CGzJ23EmOxMDpeQ9HP6qE7VuTa9b3XkhJSFUuPC4wYh0IzFzPmmONdz+3rng+Jlxy9dZPb03+obQBstses3HLbWBbv3b1iLmKV5d2TdQCMevJVjEMr3wByyoWGyJ4DipKdgDRjQbEj7BOz9J/EWm4zoJlGEe86elgFmqSClIYNygH+1zFePiQyhFDjfKhBFTy10aJv0hsfdFdC78WAm2WMuOCgdO495+CmA3n2q8kik8HiG+pvsBUEfuI/O0oFNY94tceMWeRapBvMYak5IksWzxW6uE3Qv3r/ETBTZUr/wkJj8BFZgzY0fXQ48+bquTmZBl2quR/HB+May4xsB9k97I1GQVKTDcEjWE1SGsr7tvmx39gLsVL7Hnjxco9ezOIPrD+3EY+0LTBBesP1tRJKxGSe3+pZoSU+Zfm0FMNYyI0U6VfOSHL1WZVBTL42Ac/rQQtc+Itevq8HZgSX0CN852XguIYu68obLb9FEpzsO67l5mevzCUA6Uf1tqiA2WjGwJavmlqi0m7HgU4JS+NOrIpAwVq+nHQ9CqWKmvx2z/pUO6KouSIhxoMQ4CjTgZ6Xx8Ym9Ga319qRUpIsgzikUfELkJtWCfmhdXukH105PxQv3OsxdOX0r96UU8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB7056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWZ0ZHdzQk4xVGhHSm1pa0VURkpSWkNTVGRpR3UzODExd2hwYVdtT1hkOFpi?= =?utf-8?B?N1VBa3dsSHV0ZCtaYmFWMVpGT1ZiRHQ2V1Voc2REOEQ1YkhtQXlFczNjUHZ0?= =?utf-8?B?b0lkeG5Rd2F1K1RRSFZkUGxXYVl1UWV4M3lCNjlQT1dNMWFIWUpEMGhOTE56?= =?utf-8?B?RC9XUHgzSFNMZ3R4dDVOKzg1NVFjeWc5blM5Vmd1ejN3RDNwQzd3VG9SbDhN?= =?utf-8?B?UnBBSzl5UisrWUFuNlZOUi9neHk0bWtZdHQ3M1RjVEo5YnFRVkVPWHhHS3lP?= =?utf-8?B?QUtyRGhZRzNObVZlOHNkaUpvdlh6SDIzSkp6SU93dmlBKzlYc2w4OUROd2pW?= =?utf-8?B?aGdyWnB6S3U3WUduOU1aaHRtSytma1B3UzhURjJsQVBDMG54U3ViMkNZZEFi?= =?utf-8?B?ampMWlBUYjZhQzZLYStHbElwcmJ6b1JhbEhnMUZRRm9zSmNsTWZEa1BqYWRF?= =?utf-8?B?VDhZdlo1MU8vK1Y1Q0tmSFZqQnJtT2piNjFoUmxWSitGcG5sSnozeDBYaGNU?= =?utf-8?B?V2NMMjEwbVJ5MnBqRU5veE5PK1ZIWXYzZ3M1K09FWWF1V3BMUW0wWEFJQ0ZJ?= =?utf-8?B?U2Jid0VveDJNQ2tOSGpDdEhoU2FEZFUwN3daWGVWODZ5ZWhabjBCaENYZTN0?= =?utf-8?B?U2l6NE9MN2VDYUFiNmZkTmwybTY3QllHOFJXMWdZS3B1YjBlZW1waTIxSVZ6?= =?utf-8?B?N3pIUnZpSG5MM3JDSk5ma3NBUWVseDJ4d2FHRllGTGN5UWVxL250S0NpOWVT?= =?utf-8?B?WTBseVcvL0srUUV4OUYzZnBxZjRnRHNmM1FkZmZ5V2xtRGFZbEcrNWtQWVhU?= =?utf-8?B?ZDVVY0ViMVBIZjJSZklEVHFVb3VwU2RPMTdzamdVc0tWa0p4cFcvMSsvVTN5?= =?utf-8?B?Z3V4b3hkL3hFWTRRa1ZlSm5xZmx1Qi8velBiUzB2cjdRaXZHMWFyQjR1TVRU?= =?utf-8?B?bGdETHQyVEhzb0s5Ynd1RkRoZ3d4eXlnRkhlRmdJaUtRbHdSdTY1dWVndXRa?= =?utf-8?B?RWpXMnltNSs2ZDR1MnRFZ3B5ZWJzNW03TzNyWXN5N2h6anVJMDFlbTBoWkNn?= =?utf-8?B?NUIzaG1MSUZ1TFN0M0tzVWdJdC9OS09NWlhWejRZbUZiN2lxL2h2QVhnYVRZ?= =?utf-8?B?Um9qSHdhQm5Ta1dYSnB6K3dBMVlxUnJYYzlpaUZtOHEzd3pkOWU0VnJUMnAz?= =?utf-8?B?UEFRWFhmNFlEMjhZUE8vQmhndWZyazFvUUMwYUZtTWo3ZHBGcnpSOFVkV0Jr?= =?utf-8?B?emY5UWJyQmVNQXZOdlN6a1l0cGpHOXViM004TDYrQklqR0o3a2d0TUluZlUw?= =?utf-8?B?REY0WWluc2VCYTB4dmNpb01UZ3YwVjRsUHRJYVV1MUxkSFFSejBmZjBLZHZV?= =?utf-8?B?UVMxYVFxZ291WEZmZXgwdWxIV1pYYnltM0xQYWJEY2ljR0RYKy9vd1BZVHNX?= =?utf-8?B?WElwT05RdnFZQlZ0RGJTWlUwbXdmWmJwcllFSlI3U2hVNER1ek41L1FzTUZw?= =?utf-8?B?V3pLYWVsQlJuLzBVOG1IRGlKMUNsdHVSdEVlQjlNTitkaVFxRVYxekZraTdF?= =?utf-8?B?S3ptQ2t4VXJYY2xtZWMzVHgxODBsbHBvZ1pUWXdUYk1uc1B2T0NvODdqMVRC?= =?utf-8?B?NkZ2UTQ2M25mOUNSSCtMRk5wdnBiQUtGWEVRbWttR3cvRnF1R3BpZHRDVlo3?= =?utf-8?B?eUR5R3ZBQmRZM0NkYmpHeU93d1RlSjBzTjhmVVRzcEJGUHB1aEI5SU01dXpK?= =?utf-8?B?cS9YejZydU0xZGR0VjROUnJ5S24vUXpaMVJKZFRrYkdSeHVSdTJxYWdrbjdM?= =?utf-8?B?ZmNmc1VUSVNNYUJpWUdRWWFaSHFzSGhuZzJHNEtnZ2lUMDF6M3VlYmQ1RmF1?= =?utf-8?B?WDNiWHh2YUF1Z010UURJbUFkRmNCU1dBZk9ycGpHT2tUUlFzUEdMRWZFV2Q2?= =?utf-8?B?UnFLZktYV3IycVVnZjFMWmJacFpKUmhkZm1pc0xYOTRrN1orRldqU2toY1VY?= =?utf-8?B?T1FhOHZkYzh2cldMeisvSU8xQVI0SzFib2I2ckM0RWVGZ2xrT2VDMm9KN3ov?= =?utf-8?B?NldUMlRHYVJBTHV4ejNqT1lzM1Fta1RSb2VxcWxhZjcrSkpzUktnY21nL0Zu?= =?utf-8?B?eDduZStZcnNXUkdMb0MxMjZ3dkh3MjB6UEpoWjlFdXY3QzltL1BhMkRrYVAy?= =?utf-8?B?Mmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4c6d6f1a-b5c1-44b7-7de1-08dc58aaf9fd X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 15:37:34.4642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f5B0GU4nszviouhluiMhkZ8hWI/k10PngUGbL+TYhhJm5Q3Thj9Foe7iOHEUysnQVlRl5m0ABeNk/JvUwBKC1kdB5DBabuknNVIIH8jdUY4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB8293 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------Ry7dj33dL23jqi0qo0j8QUdq Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 09-04-2024 21:01, Michal Wajdeczko wrote: > Although it's unlikely that drmm_mutex_init() will fail during > driver initialization, however we shouldn't ignore this case. > > Signed-off-by: Michal Wajdeczko > --- > drivers/gpu/drm/xe/xe_device.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index 9083f5e02dd9..ba3643906d9e 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -273,7 +273,9 @@ struct xe_device *xe_device_create(struct pci_dev *pdev, > > init_waitqueue_head(&xe->ufence_wq); > > - drmm_mutex_init(&xe->drm, &xe->usm.lock); > + err = drmm_mutex_init(&xe->drm, &xe->usm.lock); > + if (err) > + goto err; LGTM. Reviewed-by: Himal Prasad Ghimiray > xa_init_flags(&xe->usm.asid_to_vm, XA_FLAGS_ALLOC); > > if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) { --------------Ry7dj33dL23jqi0qo0j8QUdq Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 09-04-2024 21:01, Michal Wajdeczko wrote:
Although it's unlikely that drmm_mutex_init() will fail during
driver initialization, however we shouldn't ignore this case.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 9083f5e02dd9..ba3643906d9e 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -273,7 +273,9 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
 
 	init_waitqueue_head(&xe->ufence_wq);
 
-	drmm_mutex_init(&xe->drm, &xe->usm.lock);
+	err = drmm_mutex_init(&xe->drm, &xe->usm.lock);
+	if (err)
+		goto err;

LGTM.

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

 	xa_init_flags(&xe->usm.asid_to_vm, XA_FLAGS_ALLOC);
 
 	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {
--------------Ry7dj33dL23jqi0qo0j8QUdq--