Re: [PATCH] !fixup: drm/xe/gsc: GSC FW load

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 12/7/2023 12:55 PM, Mika Kuoppala wrote:
> Fix timeout to be in usecs for xe_mmio_wait32
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Thanks for catching this.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/xe/xe_gsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gsc.c b/drivers/gpu/drm/xe/xe_gsc.c
> index 4aad6a8c9dde..a8a895cf4b44 100644
> --- a/drivers/gpu/drm/xe/xe_gsc.c
> +++ b/drivers/gpu/drm/xe/xe_gsc.c
> @@ -182,7 +182,7 @@ static int gsc_fw_wait(struct xe_gt *gt)
>   	return xe_mmio_wait32(gt, HECI_FWSTS1(MTL_GSC_HECI1_BASE),
>   			      HECI1_FWSTS1_INIT_COMPLETE,
>   			      HECI1_FWSTS1_INIT_COMPLETE,
> -			      500, NULL, false);
> +			      500 * USEC_PER_MSEC, NULL, false);
>   }
>   
>   static int gsc_upload(struct xe_gsc *gsc)