Re: [PATCH v1] drm/xe/throttle: Skip reason prefix while emitting array

["Anirban, Sk" <sk.anirban@intel.com>]

Hi,

On 03-12-2025 06:03 pm, Raag Jadav wrote:
> The newly introduced "reasons" attribute already signifies possible
> reasons for throttling and makes the prefix in individual attribute
> names redundant while emitting them as an array. Skip the prefix.
>
> Fixes: 83ccde67a3f7 ("drm/xe/gt_throttle: Avoid TOCTOU when monitoring reasons")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_throttle.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_throttle.c b/drivers/gpu/drm/xe/xe_gt_throttle.c
> index 096a6187ff12..570358310e97 100644
> --- a/drivers/gpu/drm/xe/xe_gt_throttle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_throttle.c
> @@ -137,7 +137,7 @@ static ssize_t reasons_show(struct kobject *kobj,
>   		struct throttle_attribute *other_ta = kobj_attribute_to_throttle(kattr);
>   
>   		if (other_ta->mask != U32_MAX && reasons & other_ta->mask)
> -			ret += sysfs_emit_at(buff, ret, "%s ", (*pother)->name);
> +			ret += sysfs_emit_at(buff, ret, "%s ", (*pother)->name + strlen("reason_"));
>   	}
>   
>   	if (drm_WARN_ONCE(&xe->drm, !ret, "Unknown reason: %#x\n", reasons))
LGTM.

Reviewed-by: Sk Anirban <sk.anirban@intel.com>


Anirban