Re: [PATCH] drm/xe/vm: fix xe_assert()

[Nirmoy Das <nirmoy.das@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]


On 3/18/2024 11:36 AM, Matthew Auld wrote:
> The region can be used an index into the region_to_mem_type, so we
> should be asserting that it is less than the ARRAY_SIZE here.
>
> Signed-off-by: Matthew Auld<matthew.auld@intel.com>
> Cc: Nirmoy Das<nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index cbb9b8935c90..51d62323d9ee 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2033,7 +2033,7 @@ static int xe_vm_prefetch(struct xe_vm *vm, struct xe_vma *vma,
>   	struct xe_exec_queue *wait_exec_queue = to_wait_exec_queue(vm, q);
>   	int err;
>   
> -	xe_assert(vm->xe, region <= ARRAY_SIZE(region_to_mem_type));
> +	xe_assert(vm->xe, region < ARRAY_SIZE(region_to_mem_type));
>   
>   	if (!xe_vma_has_no_bo(vma)) {
>   		err = xe_bo_migrate(xe_vma_bo(vma), region_to_mem_type[region]);

[-- Attachment #2: Type: text/html, Size: 1775 bytes --]