From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7558EB7EA1 for ; Wed, 4 Mar 2026 08:30:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B8AD10E15B; Wed, 4 Mar 2026 08:30:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dpIGWoAs"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 313C010E979; Wed, 4 Mar 2026 08:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772613020; x=1804149020; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mp9zMsFj1crKWQWsG/YFBfCHeFkesRYiNEgMhSLYSaw=; b=dpIGWoAsWiAnn88RTfUVelZsCLvstEdcApEYpfA1/w8CFh0TcgtQFtOQ cHqHDaAI9FTHgkqf5HZwwHkjoz3XGQ15NRTxZDLe2ODK3TXSG/5LJ0rko fqWQlfrRfmsGvRXu7MaglloNbx4VzRdDqrZ0V3VNU8+PtfZCkl0qn4YIX 75Q5tHPl4BGO8A2LvM7KZQ74nzssmgKbvFoDMmNhMQ39MPKMmbqVIMolT Dd0RornEeAwYA9EM0EiRGJp9XVauXghvW0o50s9TU7Km/qGI8laPq1i1J g6VOBUFeL26/SAv9UKxHEa0t75mnXI69bbfnyfbZedkZkLUuk6gBfLvTN g==; X-CSE-ConnectionGUID: JQEbMjYIQdCYP2eAaPLOcA== X-CSE-MsgGUID: WRy/LEmoTXuWP6UD/rWwZA== X-IronPort-AV: E=McAfee;i="6800,10657,11718"; a="73794511" X-IronPort-AV: E=Sophos;i="6.21,323,1763452800"; d="scan'208";a="73794511" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2026 00:30:11 -0800 X-CSE-ConnectionGUID: 0LiY+/uJTluHJEmJ71zJMQ== X-CSE-MsgGUID: SgDsOcDWTn+St2v7I/uplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,323,1763452800"; d="scan'208";a="217433706" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO [10.245.245.178]) ([10.245.245.178]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2026 00:30:10 -0800 Message-ID: <77e5ca2b-7473-44d1-ba4b-8a301adcd788@linux.intel.com> Date: Wed, 4 Mar 2026 09:29:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/dp: Add definition for Panel Replay full-line granularity To: "Hogander, Jouni" , "Shankar, Uma" , "intel-xe@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" Cc: "dri-devel@lists.freedesktop.org" References: <20260225074221.1744330-1-jouni.hogander@intel.com> Content-Language: en-US From: Maarten Lankhorst In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hey, Den 2026-02-27 kl. 06:49, skrev Hogander, Jouni: > On Thu, 2026-02-26 at 21:02 +0000, Shankar, Uma wrote: >> >> >>> -----Original Message----- >>> From: Intel-xe On Behalf >>> Of Jouni >>> Högander >>> Sent: Wednesday, February 25, 2026 1:12 PM >>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org >>> Cc: Hogander, Jouni ; >>> dri-devel@lists.freedesktop.org >>> Subject: [PATCH 1/2] drm/dp: Add definition for Panel Replay full- >>> line granularity >>> >>> DP specification is saying value 0xff 0xff in PANEL REPLAY >>> SELECTIVE >>> UPDATE X GRANULARITY CAPABILITY registers (0xb2 and 0xb3) means >>> full- >>> line granularity. Add definition for this. >> >> I think it would be good to call this also out also in comment: >> "The SU region width shall be equal to the horizontal width of the >> timing being transported" >> This clarifies what is meant by full line granularity here. > > I will add this comment. > >> >>> >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Jouni Högander >>> --- >>>  include/drm/display/drm_dp.h | 2 ++ >>>  1 file changed, 2 insertions(+) >>> >>> diff --git a/include/drm/display/drm_dp.h >>> b/include/drm/display/drm_dp.h index >>> e4eebabab975..8b15d3eeb716 100644 >>> --- a/include/drm/display/drm_dp.h >>> +++ b/include/drm/display/drm_dp.h >>> @@ -571,6 +571,8 @@ >>>  # define >>> DP_PANEL_REPLAY_LINK_OFF_SUPPORTED_IN_PR_AFTER_ADAPTIVE_SYN >>> C_SDP (1 << 7) >>> >>>  #define DP_PANEL_REPLAY_CAP_X_GRANULARITY 0xb2 >>> +# define DP_PANEL_REPLAY_FULL_LINE_GRANULARITY 0xffff >> >> Space in #define can be removed. > > I followed convention used elsewhere in drm_dp.h. I.e. register field > definitions have this extra space. What do you think? > > BR, > Jouni Högander Seems to be the convention here, so fine with me. For merging through drm-intel: Acked-by: Maarten Lankhorst >> >> With above fixed, Change looks good to me. >> Reviewed-by: Uma Shankar >> >>>  #define DP_PANEL_REPLAY_CAP_Y_GRANULARITY 0xb4 >>> >>>  /* Link Configuration */ >>> -- >>> 2.43.0 >> >