From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEB48CCF9F0 for ; Thu, 30 Oct 2025 13:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 649B710E269; Thu, 30 Oct 2025 13:04:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="QQuycoPs"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ei5WI6UG"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96B7D10E758 for ; Wed, 29 Oct 2025 09:42:38 +0000 (UTC) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59T93HEw4155563 for ; Wed, 29 Oct 2025 09:42:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MmgRKySPBYPzkhHOeDW0BeEkxDUdUPpQf5CBxkBMstI=; b=QQuycoPs+C/VeFQM etXGcA454gTXTyTo+Z0pkOabIRfNOIDe5qcGphTys7OTdaXoZ6lCv6fhWR8TdhIp QKhZAvzohOpCHrveLE883tDiUVxPXIftlLBEIGuz18V9BjEzPu/SwVnZqfyr8HRL N2jAhAN8wCSosm1UvKGweyNQY8NIYfQ8sfFlrUAytVkQro0hWt3NfHiHvoCGGC0F CRylK4rV+9q5mXlHJScqWfiOThdJaDUiSZMUB6KdBWiuwcadmmQtadRwBBZX4Jmm R9mWcHxphDVBhc1fI3VSIMaaQUFmsDYKPbUyVMfLT9V3bs03igtoxmx3Q1ST37O9 xkkFPA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a3fy0r4a0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Oct 2025 09:42:37 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8a03b09b54eso111022285a.0 for ; Wed, 29 Oct 2025 02:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761730957; x=1762335757; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MmgRKySPBYPzkhHOeDW0BeEkxDUdUPpQf5CBxkBMstI=; b=Ei5WI6UGxcM1H32alnZI0m6w02LT39h6DgzOL5vlg3JZ7RiPuG8xZ1sYThOvSz9/Jk ckV0YZDCB7N8eo8//JkstqOhCt6LVkwg/662MnQtx7/mVLChdL1sl+y1njwDt7lz/YzJ dpTVMbroSkUbxTwqgfKZ3O16vgcyRwyVH5TlTn7oQ9R1n46SqSaAXol/TCJsrJvD1W1U 8F3lIhepwD6tcl6RRPT8t3Ulfid4SlD51uMggcFyE8UOtHFwmF9kmYt3OUOg/F5rW5Pc G1eMTh45Qpm6onFkcUhABboizxlEbV5UPvUzX5lkKQk9kS+qrQkKjFpGCnSu+S50Bia0 vHlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761730957; x=1762335757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MmgRKySPBYPzkhHOeDW0BeEkxDUdUPpQf5CBxkBMstI=; b=iAm7AHnBCVQ+9dOKnmE5gEqKlNIM0wpAfbOLBVwvZrBzvjjY1vDwNSbQGFrNaVwmX+ MgW71gAjtfN7XKPEhVB2fj4xqK73sBN/Lq2a0r8Yh0Ld9gWfb53gzS4X1Z97qSLjX3z1 yHgtxFQxTlWn7veuYgiS5gcJuK226nAZJ3+aLJTjhLp3k2z1xR+uRKPpLhZnEgzKqSPM 9YTyz/3xlGUiLnl+H9l+6h/i7/LNcdWGJf3whDDe2hbJ5Ji+piUuzOZQEvR/2UbUGw+I oOcGhWVMYsCaJ+gS7CJBxB3hcjDHZ1CN42WGJmg27MQlBIqMMODaCUtCy9aepkH+9Rg/ ZfLA== X-Forwarded-Encrypted: i=1; AJvYcCVS8WE32+WNZ+ue3PpttBs65LxP9e+FcQ/NvDf+fQAYVZpou0VuGCmfSowMSuKOLUb8qHngIpee1w==@lists.freedesktop.org X-Gm-Message-State: AOJu0YyLDAmtGP1mcgiz0rcPJwARkQUkwwY7v/vRrkegZvSoVS/MCv2y BsHHBt1ISPQatBmnssLwF5hhMIPaY7aYG2VL1ANrOlBk4o7hWtS/O722d20irUJ00gzCCIA3/cV FqL9bC/l+iw/GAcdr/NWjFuIl9MvMPyo5a8aHc9OgRby7kblihG1wVdtCGbGbkyI/4ZShXw== X-Gm-Gg: ASbGncsBnqGhHMEQ7Wp8Et492t/ATMiFaUy51eRmDxr5prM3fa6/eh6iSCNBxUzuos+ 5QHS1p+tix6Hv/8qM/zo5Je20xdDHJGif1A0PocsshqCAIMlTWndUatBcRjFG5fls2CMBlLOr8r FwvN9SFjLelzCND5GeErcb3LFbolkgRIdbnSMX5hDpDplPOVYV0LFgBmHMDwfE+fkWj6AteCd8r k68E/fJIplUoOSy87dbaWXAXYz/sXj0ZXnjyx0P2EAPjvq5/JaKCWkhd+3vm8j1h2qx9x5QVtq9 ec1oEoKl05/jHePmfE93tTyjS2S9ou7iPdK4CBiHeqU24cLWLVq4oz0uk3+7H0/rHQKRXOQn19h QntQQuSXxCKs4Wkiw5DBiBqAe/UE932BBxtyRtEloYiWD1omQ5v/iO3jv X-Received: by 2002:a05:620a:bce:b0:878:408d:c09a with SMTP id af79cd13be357-8a8e34d22c9mr206432885a.4.1761730956917; Wed, 29 Oct 2025 02:42:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyzw2uooaE3FP8gd0prarw9B+NMvunoxzP7rKqKh5OTI7VSeSeyuZJuSI/cuTYOFoNrAsYcA== X-Received: by 2002:a05:620a:bce:b0:878:408d:c09a with SMTP id af79cd13be357-8a8e34d22c9mr206430585a.4.1761730956406; Wed, 29 Oct 2025 02:42:36 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d8541e99fsm1389534266b.61.2025.10.29.02.42.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 02:42:35 -0700 (PDT) Message-ID: <78679e08-2a38-477b-a080-be0442465fbe@oss.qualcomm.com> Date: Wed, 29 Oct 2025 10:42:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/display/dp: Rename bit 4 of DPCD TEST_REQUEST to match DP2.1 spec To: Khaled Almahallawy , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Jani Nikula , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul References: <20251028222817.3290035-1-khaled.almahallawy@intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251028222817.3290035-1-khaled.almahallawy@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=VJLQXtPX c=1 sm=1 tr=0 ts=6901e18d cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=DweoPDKG-9ER2baVzYcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: dtxpqh7F4_13NhG9AAuQKrP0pOVWtDk_ X-Proofpoint-ORIG-GUID: dtxpqh7F4_13NhG9AAuQKrP0pOVWtDk_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI5MDA3MiBTYWx0ZWRfXx+OQ62qmdOe/ jZUKO3lz/rj5RgMD7dtE5xHA5QGMXz4cINUOMp+iqxMl2EKvew/soFS8tkk0owMRaHXmRKedlqd if/Fm4ap9sBqH48DrEflIR7i+HNqn8Ot/Mc7l6W0qHTEA64chZ88OmJyqg0bJpn2wpVGPOLr5Hy Hy70eQ1aBs6jAul/5ytmhMk7HAkaqFw8WOJjS/fsZ0brID/aB435tz6rd7bivesXooVAOR/IKbg JYWojobKXLO/T+QqyGKrqO27HTojdg73HjnhNR1KGPu3E9YDf5tfOwz0I+kE3qLKSnXkiRgT26u 4ZPX9meV36U43qaPm0WngQtoa+8vcWB8I+p9Hbi4bYjnCpKF1EtqOr6nMkLdocgWsUdyAhpuAvF 4vuZSqo/9T2RJ1HRv86uBZHS7NcN0A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_04,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1011 priorityscore=1501 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510290072 X-Mailman-Approved-At: Thu, 30 Oct 2025 13:04:45 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 10/28/25 11:28 PM, Khaled Almahallawy wrote: > The DP_TEST_LINK_FAUX_PATTERN field was deprecated in the DP 1.3 spec. > Update its name to align with the DP 2.1 definition and reflect its > actual use in the code. No functional changes. > > Cc: Jani Nikula > Cc: Rob Clark > Cc: Dmitry Baryshkov > Cc: Abhinav Kumar > Cc: Sean Paul > Signed-off-by: Khaled Almahallawy > --- > drivers/gpu/drm/msm/dp/dp_link.c | 2 +- > include/drm/display/drm_dp.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c > index 66e1bbd80db3..5d465cf4dbc2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_link.c > +++ b/drivers/gpu/drm/msm/dp/dp_link.c > @@ -665,7 +665,7 @@ static int msm_dp_link_parse_request(struct msm_dp_link_private *link) > return rlen; > } > > - if (!data || (data == DP_TEST_LINK_FAUX_PATTERN)) { > + if (!data || (data == DP_TEST_PHY_TEST_CHANNEL_CODING_TYPE)) { > drm_dbg_dp(link->drm_dev, "link 0x%x not supported\n", data); > goto end; > } > diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h > index e4eebabab975..610b8cbf1125 100644 > --- a/include/drm/display/drm_dp.h > +++ b/include/drm/display/drm_dp.h > @@ -849,7 +849,7 @@ > # define DP_TEST_LINK_VIDEO_PATTERN (1 << 1) > # define DP_TEST_LINK_EDID_READ (1 << 2) > # define DP_TEST_LINK_PHY_TEST_PATTERN (1 << 3) /* DPCD >= 1.1 */ > -# define DP_TEST_LINK_FAUX_PATTERN (1 << 4) /* DPCD >= 1.2 */ > +# define DP_TEST_PHY_TEST_CHANNEL_CODING_TYPE (1 << 4) I think it'd be useful to keep a comment of what it was before the deprecation and rename Konrad